From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uf6eH-00052E-0x for qemu-devel@nongnu.org; Wed, 22 May 2013 06:52:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uf6eC-0005jU-HO for qemu-devel@nongnu.org; Wed, 22 May 2013 06:52:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13123) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uf6eC-0005jK-8v for qemu-devel@nongnu.org; Wed, 22 May 2013 06:51:56 -0400 Message-ID: <519CA33E.9010109@redhat.com> Date: Wed, 22 May 2013 12:51:42 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20130521220917.GA803@redhat.com> <87obc34fy3.fsf@blackfin.pond.sub.org> <20130522083732.GD7993@redhat.com> <519C8541.6060605@redhat.com> <20130522085219.GF7993@redhat.com> <519C8E6C.3000107@redhat.com> <20130522094210.GA24931@redhat.com> <519CA097.5000804@redhat.com> <20130522105034.GA5643@redhat.com> In-Reply-To: <20130522105034.GA5643@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] makefile: detect corrupted elf files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Peter Maydell , Anthony Liguori , qemu-devel@nongnu.org, Markus Armbruster , Luiz Capitulino , Blue Swirl Il 22/05/2013 12:50, Michael S. Tsirkin ha scritto: > On Wed, May 22, 2013 at 12:40:23PM +0200, Paolo Bonzini wrote: >> Il 22/05/2013 11:42, Michael S. Tsirkin ha scritto: >>> On Wed, May 22, 2013 at 11:22:52AM +0200, Paolo Bonzini wrote: >>>> Il 22/05/2013 10:52, Michael S. Tsirkin ha scritto: >>>>> The fix is simple here: don't use ccache. I don't. >>>>> >>>>> In fact, from what I saw people use ccache to work around makefile bugs, >>>>> so they can do make clean; make and have it finish quickly. >>>>> >>>>> Any other examples? >>>> >>>> Testing configure patches should be done (also) from a clean build >>>> directory, for example. >>> >>> In fact, relying on make clean for testing the build >>> system is a mistake. It's easy for it to forget to >>> remove some temporary file. You really should do >>> a clean clone. >> >> Yes, I use a clean clone (and a clean build directory for each patch), >> _hence_ ccache helps reducing test times. > > I see, this workflow is the exact reverse of mine: > > I do as much as possible in a single tree so I > rely on the makefile dependencies to be correct > to rebuild the right things. Usually I do the same---I just do slightly more thorough testing for configure patches. Paolo