From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57441) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uf7tK-0001N8-F2 for qemu-devel@nongnu.org; Wed, 22 May 2013 08:11:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uf7tF-00009F-DR for qemu-devel@nongnu.org; Wed, 22 May 2013 08:11:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23257) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uf7tF-00008p-67 for qemu-devel@nongnu.org; Wed, 22 May 2013 08:11:33 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4MCBVlE005767 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 22 May 2013 08:11:31 -0400 Message-ID: <519CB5F1.7060600@redhat.com> Date: Wed, 22 May 2013 09:11:29 -0300 From: Lucas Meneghel Rodrigues MIME-Version: 1.0 References: <1369210609-24023-1-git-send-email-stefanha@redhat.com> In-Reply-To: <1369210609-24023-1-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] tests: set MALLOC_PERTURB_ to expose memory bugs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Markus Armbruster On 22/05/13 05:16 AM, Stefan Hajnoczi wrote: > glibc wipes malloc(3) memory when the MALLOC_PERTURB_ environment > variable is set. The value of the environment variable determines the > bit pattern used to wipe memory. For more information, see > http://udrepper.livejournal.com/11429.html. > > Set MALLOC_PERTURB_ for gtester and qemu-iotests. Note we pick a random > value from 1 to 255 to expose more bugs. If you need to reproduce a > crash use 'show environment' in gdb to extract the MALLOC_PERTURB_ > value from a core dump. > > Both make check and qemu-iotests pass with MALLOC_PERTURB_ enabled. This looks good to me, thanks Stefan! Acked-by: Lucas Meneghel Rodrigues > Signed-off-by: Stefan Hajnoczi > --- > v3: > * Use $ escaping in tests/Makefile [eblake] > > v2: > * Randomize MALLOC_PERTURB_ value [armbru] > * Preserve existing MALLOC_PERTURB_ variable, if set [danpb] > > tests/Makefile | 5 ++++- > tests/qemu-iotests/check | 3 ++- > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/tests/Makefile b/tests/Makefile > index a307d5a..7844cd7 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -171,6 +171,7 @@ GCOV_OPTIONS = -n $(if $(V),-f,) > $(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: $(check-qtest-y) > $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,) > $(call quiet-command,QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \ > + MALLOC_PERTURB_=$${MALLOC_PERTURB_:-$$(($$RANDOM % 255 + 1))} \ > gtester $(GTESTER_OPTIONS) -m=$(SPEED) $(check-qtest-$*-y),"GTESTER $@") > $(if $(CONFIG_GCOV),@for f in $(gcov-files-$*-y); do \ > echo Gcov report for $$f:;\ > @@ -180,7 +181,9 @@ $(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: $(check-qtest-y) > .PHONY: $(patsubst %, check-%, $(check-unit-y)) > $(patsubst %, check-%, $(check-unit-y)): check-%: % > $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,) > - $(call quiet-command,gtester $(GTESTER_OPTIONS) -m=$(SPEED) $*,"GTESTER $*") > + $(call quiet-command, \ > + MALLOC_PERTURB_=$${MALLOC_PERTURB_:-$$(($$RANDOM % 255 + 1))} \ > + gtester $(GTESTER_OPTIONS) -m=$(SPEED) $*,"GTESTER $*") > $(if $(CONFIG_GCOV),@for f in $(gcov-files-$(subst tests/,,$*)-y); do \ > echo Gcov report for $$f:;\ > $(GCOV) $(GCOV_OPTIONS) $$f -o `dirname $$f`; \ > diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check > index 432732c..74628ae 100755 > --- a/tests/qemu-iotests/check > +++ b/tests/qemu-iotests/check > @@ -214,7 +214,8 @@ do > start=`_wallclock` > $timestamp && echo -n " ["`date "+%T"`"]" > [ ! -x $seq ] && chmod u+x $seq # ensure we can run it > - ./$seq >$tmp.out 2>&1 > + MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(($RANDOM % 255 + 1))} \ > + ./$seq >$tmp.out 2>&1 > sts=$? > $timestamp && _timestamp > stop=`_wallclock` >