From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfEs7-0004il-DI for qemu-devel@nongnu.org; Wed, 22 May 2013 15:38:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UfEs0-0002Tk-FW for qemu-devel@nongnu.org; Wed, 22 May 2013 15:38:51 -0400 Message-ID: <519D1F42.5080108@redhat.com> Date: Wed, 22 May 2013 21:40:50 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <1369240371-21253-1-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1369240371-21253-1-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] wdt_i6300esb: fix vmstate versioning List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: peter.maydell@linaro.org, nick@bytemark.co.uk, qemu-devel@nongnu.org, qemu-stable@nongnu.org On 05/22/13 18:32, Michael Roth wrote: > When this VMSD was introduced it's version fields were set to > sizeof(I6300State), making them essentially random from build to build, > version to version. > > To fix this, we lock in a high version id and low minimum version id to > support old->new migration from all prior versions of this device's > state. This should work since the device state has not changed since > its introduction. > > The potentially breaks migration from 1.5+ to 1.5, but since the > versioning was essentially random prior to this patch, new->old > migration was not consistently functional to begin with. > > Reported-by: Nicholas Thomas > Suggested-by: Peter Maydell > Cc: qemu-stable@nongnu.org > Signed-off-by: Michael Roth > --- > v2: > * Fixed s/except/accept/ typo (Laszlo) > > hw/watchdog/wdt_i6300esb.c | 19 ++++++++++++++++--- > 1 file changed, 16 insertions(+), 3 deletions(-) Always alert to make a difference :), Reviewed-by: Laszlo Ersek