From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfVCo-0001sk-Fg for qemu-devel@nongnu.org; Thu, 23 May 2013 09:05:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UfVCm-0003t2-7j for qemu-devel@nongnu.org; Thu, 23 May 2013 09:05:18 -0400 Message-ID: <519E1408.4060602@suse.de> Date: Thu, 23 May 2013 15:05:12 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1369292323-31762-1-git-send-email-lig.fnst@cn.fujitsu.com> In-Reply-To: <1369292323-31762-1-git-send-email-lig.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH][v4 1/3] debugcon: fix always print "addr=0x0, val=0x0" bug when use DEBUG_DEBUGCON List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: liguang Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Am 23.05.2013 08:58, schrieb liguang: > when use DEBUG_DEBUGCON, screen spits: > debugcon: write addr=3D0x0000 val=3D0x00 > Rdebugcon: write addr=3D0x0000 val=3D0x00 > udebugcon: write addr=3D0x0000 val=3D0x00 > ndebugcon: write addr=3D0x0000 val=3D0x00 > ndebugcon: write addr=3D0x0000 val=3D0x00 > idebugcon: write addr=3D0x0000 val=3D0x00 > ndebugcon: write addr=3D0x0000 val=3D0x00 > gdebugcon: write addr=3D0x0000 val=3D0x00 > debugcon: write addr=3D0x0000 val=3D0x00 > odebugcon: write addr=3D0x0000 val=3D0x00 > pdebugcon: write addr=3D0x0000 val=3D0x00 > tdebugcon: write addr=3D0x0000 val=3D0x00 > idebugcon: write addr=3D0x0000 val=3D0x00 > odebugcon: write addr=3D0x0000 val=3D0x00 > ndebugcon: write addr=3D0x0000 val=3D0x00 > debugcon: write addr=3D0x0000 val=3D0x00 > rdebugcon: write addr=3D0x0000 val=3D0x00 > odebugcon: write addr=3D0x0000 val=3D0x00 > mdebugcon: write addr=3D0x0000 val=3D0x00 > debugcon: write addr=3D0x0000 val=3D0x00 > adebugcon: write addr=3D0x0000 val=3D0x00 > tdebugcon: write addr=3D0x0000 val=3D0x00 > debugcon: write addr=3D0x0000 val=3D0x00 >=20 > Oh, that's wrong, val is not always be 0. > this bug caused by lack of length modifier > for specifier 'x'. >=20 > Signed-off-by: liguang > --- > v4: fix misleading subject As I've reminded before, please prepend a cover letter (0/x) when sending more than once patch! > --- > hw/char/debugcon.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) >=20 > diff --git a/hw/char/debugcon.c b/hw/char/debugcon.c > index 02c9577..7e41c90 100644 > --- a/hw/char/debugcon.c > +++ b/hw/char/debugcon.c > @@ -55,7 +55,7 @@ static void debugcon_ioport_write(void *opaque, hwadd= r addr, uint64_t val, > unsigned char ch =3D val; > =20 > #ifdef DEBUG_DEBUGCON > - printf("debugcon: write addr=3D0x%04x val=3D0x%02x\n", addr, val); > + printf("debugcon: write addr=3D0x%04" HWADDR_PRIx " val=3D0x%02x\n= ", addr, val); Please merge 3/3 with this patch - the changes are pretty obviously correct, so you can shorten the commit message by dropping the example output. Andreas > #endif > =20 > qemu_chr_fe_write(s->chr, &ch, 1); >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg