From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfX4R-0000c4-JY for qemu-devel@nongnu.org; Thu, 23 May 2013 11:04:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UfX4P-0000eU-2S for qemu-devel@nongnu.org; Thu, 23 May 2013 11:04:47 -0400 Received: from david.siemens.de ([192.35.17.14]:22511) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfX4O-0008O8-3s for qemu-devel@nongnu.org; Thu, 23 May 2013 11:04:44 -0400 Message-ID: <519E2608.8050702@siemens.com> Date: Thu, 23 May 2013 16:22:00 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1369133851-1894-1-git-send-email-pbonzini@redhat.com> <1369133851-1894-16-git-send-email-pbonzini@redhat.com> <20130523120533.GA26259@boomeroo.fritz.box> In-Reply-To: <20130523120533.GA26259@boomeroo.fritz.box> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: Paolo Bonzini , qemu-devel@nongnu.org, peter.maydell@linaro.org On 2013-05-23 14:05, David Gibson wrote: > On Tue, May 21, 2013 at 12:57:16PM +0200, Paolo Bonzini wrote: >> The old-style IOMMU lets you check whether an access is valid in a >> given DMAContext. There is no equivalent for AddressSpace in the >> memory API, implement it with a lookup of the dispatch tree. > > I don't love the name - "address_space_valid" suggests to me it tests > the validity of the whole address space, not a specific range. But > an obviously better name doesn't quickly occur to me. Not sure ATM if someone else suggested this earlier already, but what about something like address_space_access_valid? Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux