From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35370) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfWsT-00085p-AB for qemu-devel@nongnu.org; Thu, 23 May 2013 10:52:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UfWsN-0005Fa-Mz for qemu-devel@nongnu.org; Thu, 23 May 2013 10:52:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30422) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfWsN-0005FT-Dh for qemu-devel@nongnu.org; Thu, 23 May 2013 10:52:19 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4NEqI5j006146 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 23 May 2013 10:52:18 -0400 Message-ID: <519E2D20.9060003@redhat.com> Date: Thu, 23 May 2013 08:52:16 -0600 From: Eric Blake MIME-Version: 1.0 References: <1369300080-31377-1-git-send-email-akong@redhat.com> <1369300080-31377-2-git-send-email-akong@redhat.com> <20130523102459.GD16892@redhat.com> <20130523102842.61a02d2e@redhat.com> <20130523144325.GC24037@redhat.com> In-Reply-To: <20130523144325.GC24037@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2NAPALKILHINMUASKNPVT" Subject: Re: [Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Amos Kong , qemu-devel@nongnu.org, stefanha@redhat.com, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2NAPALKILHINMUASKNPVT Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/23/2013 08:43 AM, Michael S. Tsirkin wrote: >>> Please stress this is only for the NIC. It does not apply >>> to non-NIC netclients. >> >> Stress it in the event name too, please. I find RX_FILTER_CHANGED a bi= t >> generic. >=20 > What do you suggest? > NIC_RX_FILTER_CHANGED ? Yes, that might work. (And whatever name we bikeshed, insert it in the correct sorted order in the file) >=20 >> Also, although I haven't reviewed the next patch yet, I think you >> should move the event trigger to this patch. >=20 > That's hard because of the flag that's shared with the query > command. It's fine if this patch declares and sets the flag, but the event is one-shot until the next patch adds the query to clear the flag. And again, the flag should be per-device, not global. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2NAPALKILHINMUASKNPVT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRni0gAAoJEKeha0olJ0NqkWEH/0DX+bxcCBkcIsyxsW05pYlF W6EmWVXiToicH0hJUicut/tfzPhPL8sjnfXpH2keAfZ8opbCRTLj0uhSCjE6apQB 8+Bsf+dzOfBFBg3HdmHXugmpqUHjrw/i9lLnIniZsQ9GIshAXQVEvKdR6CUJWiGN yBYY1LjgdvUmq3d0zIqBx14Qths1sGGxieHfTxWJHP2RnkEoF7sQEGK7WB8W9CIH iuq9NnurDhpsyiw0/SHH4RzGcvuPhhpOe6+Zmpi6x/Zbpjxpsj1U2k/Ux1L/gyM/ eWyIVWUgKFChJ5l5bybLQyf75T/Y9K7g+oWXAeT9ru5B99uHzffSD8rU1FEyxnY= =bOIy -----END PGP SIGNATURE----- ------enig2NAPALKILHINMUASKNPVT--