From: Paolo Bonzini <pbonzini@redhat.com>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, Asias He <asias@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] qemu seabios issue with vhost-scsi
Date: Thu, 23 May 2013 16:58:05 +0200 [thread overview]
Message-ID: <519E2E7D.4080502@redhat.com> (raw)
In-Reply-To: <519E2C21.3000103@us.ibm.com>
Il 23/05/2013 16:48, Badari Pulavarty ha scritto:
>> The common virtio-scsi code in QEMU should guard against this. In
>> virtio-blk data plane I hit a similar case and ended up starting the
>> data plane thread (equivalent to vhost here) *before* the status
>> register is set to DRIVER_OK.
>
> Thats exactly what my debug in vhost_scsi_set_status() shows.
>
> set status started 0 val 0
> set status started 0 val 0
> set status started 0 val 0
> set status started 0 val 0
> set status started 0 val 0
> set status started 0 val 3
> Program received signal SIGSEGV, Segmentation fault.
>
> We never got a chance to call vhost_scsi_start() as we are waiting
> for DRIVER_OK.
This is the fix in SeaBIOS:
commit 5a7730db57ab0715223421e65b54fb50d6fefe5c
Author: Asias He <asias@redhat.com>
Date: Fri Mar 15 09:45:15 2013 +0800
virtio-scsi: Set _DRIVER_OK flag before scsi target scanning
Before we start scsi target scanning, we need to set the
VIRTIO_CONFIG_S_DRIVER_OK flag so the device can do setup properly.
This fix a bug when booting tcm_vhost with seabios.
Signed-off-by: Asias He <asias@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Still, Gleb is right that SeaBIOS should not be able to crash QEMU;
exit(1) is fine, SIGSEGV is not.
Paolo
next prev parent reply other threads:[~2013-05-23 14:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 0:36 [Qemu-devel] qemu seabios issue with vhost-scsi Badari
2013-05-23 0:53 ` Asias He
2013-05-23 9:48 ` Gleb Natapov
2013-05-23 13:32 ` Stefan Hajnoczi
2013-05-23 14:48 ` Badari Pulavarty
2013-05-23 14:58 ` Paolo Bonzini [this message]
2013-05-23 15:27 ` Asias He
2013-05-23 15:30 ` Paolo Bonzini
2013-05-23 16:11 ` Badari Pulavarty
2013-05-23 16:19 ` Paolo Bonzini
2013-05-23 16:38 ` Badari Pulavarty
2013-05-23 16:47 ` Paolo Bonzini
2013-05-23 17:18 ` Stefan Hajnoczi
2013-05-23 17:31 ` Paolo Bonzini
2013-05-24 0:02 ` Asias He
2013-05-23 16:08 ` Badari Pulavarty
2013-05-23 12:45 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519E2E7D.4080502@redhat.com \
--to=pbonzini@redhat.com \
--cc=asias@redhat.com \
--cc=gleb@redhat.com \
--cc=nab@linux-iscsi.org \
--cc=pbadari@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).