From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50091) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfYlg-0004Kq-Jm for qemu-devel@nongnu.org; Thu, 23 May 2013 12:53:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UfYle-0002nl-2T for qemu-devel@nongnu.org; Thu, 23 May 2013 12:53:32 -0400 Received: from mail-gh0-f172.google.com ([209.85.160.172]:49496) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfYld-0002nc-V3 for qemu-devel@nongnu.org; Thu, 23 May 2013 12:53:30 -0400 Received: by mail-gh0-f172.google.com with SMTP id r18so1296689ghr.17 for ; Thu, 23 May 2013 09:53:29 -0700 (PDT) Sender: Richard Henderson Message-ID: <519E4984.8050507@twiddle.net> Date: Thu, 23 May 2013 09:53:24 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1369310404-5285-1-git-send-email-peter.maydell@linaro.org> <1369310404-5285-11-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1369310404-5285-11-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/10] target-arm: Abstract out load/store from a vaddr in AArch32 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: John Rigby , patches@linaro.org, qemu-devel@nongnu.org, Blue Swirl , =?ISO-8859-1?Q?Andreas_F=E4rber?= , Aurelien Jarno On 05/23/2013 05:00 AM, Peter Maydell wrote: > AArch32 code (ie traditional 32 bit world) expects to be > able to pass a vaddr in a TCGv_i32. However when QEMU is > compiled with TARGET_LONG_BITS=32 the TCG load/store > functions take a TCGv_i64. Abstract out load/store with > a 32 bit vaddr so we have a place to put the zero extension > of the vaddr and the extension/truncation of the data value. > > Apart from the function definitions most of this patch is > a simple s/tcg_gen_qemu_/gen_aa32_/. > > Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson r~