From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfZnz-0007PL-BB for qemu-devel@nongnu.org; Thu, 23 May 2013 14:00:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UfZnu-0003np-Ae for qemu-devel@nongnu.org; Thu, 23 May 2013 13:59:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4792) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfZnu-0003nd-39 for qemu-devel@nongnu.org; Thu, 23 May 2013 13:59:54 -0400 Message-ID: <519E58F0.5030809@redhat.com> Date: Thu, 23 May 2013 11:59:12 -0600 From: Eric Blake MIME-Version: 1.0 References: <1369331087-22345-1-git-send-email-coreyb@linux.vnet.ibm.com> <1369331087-22345-8-git-send-email-coreyb@linux.vnet.ibm.com> In-Reply-To: <1369331087-22345-8-git-send-email-coreyb@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2GJCQMMQIJOQRUSXSXQSF" Subject: Re: [Qemu-devel] [PATCH 7/7] monitor: QMP/HMP support for retrieving VNVRAM details List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corey Bryant Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanb@linux.vnet.ibm.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com, jschopp@linux.vnet.ibm.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2GJCQMMQIJOQRUSXSXQSF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/23/2013 11:44 AM, Corey Bryant wrote: > Signed-off-by: Corey Bryant > --- Might help to list a sample HMP or QMP usage in the commit message. > +++ b/qapi-schema.json > @@ -3619,3 +3619,50 @@ > '*cpuid-input-ecx': 'int', > 'cpuid-register': 'X86CPURegister32', > 'features': 'int' } } > + > +# @VNVRAMEntryInfo: > +# > +# Information about an entry in the VNVRAM. > +# > +# @name: name of the entry > +# > +# @cur-size: current size of the entry's blob in bytes > +# > +# @max-size: max size of the entry's blob in bytes > +# > +# Since: 1.6 > +# > +## > +{ 'type': 'VNVRAMEntryInfo', > + 'data': {'name': 'str', 'cur-size': 'int', 'max-size': 'int', } } No trailing commas in JSON. :( > + > +## > +# @VNVRAMInfo: > +# > +# Information about the VNVRAM device. > +# > +# @drive-id: ID of the VNVRAM (and associated drive) > +# > +# @virtual-disk-size: Virtual size of the associated disk drive in byt= es > +# > +# @vnvram-size: Size of the VNVRAM in bytes > +# > +# @entries: Array of @VNVRAMEntryInfo > +# > +# Since: 1.6 > +# > +## > +{ 'type': 'VNVRAMInfo', > + 'data': {'drive-id': 'str', 'virtual-disk-size': 'int', > + 'vnvram-size': 'int', 'entries' : ['VNVRAMEntryInfo']} } > + > +## > +# @query-vnvram: > +# > +# Return information about the VNVRAM devices. > +# > +# Returns: @VNVRAMInfo on success > +# > +# Since: 1.6 > +## > +{ 'command': 'query-vnvram', 'returns': ['VNVRAMInfo'] } Other than that, this looks fine from an interface point of view. I haven't closely reviewed code, though. > + > +Example: > + > +-> { "execute": "query-vnvram" } > +<- {"return": [ > + { "vnvram-size": 2050, "virtual-disk-size": 2000896, > + "drive-id": "drive-ide0-0-0", > + "entries": [ > + { "name": "this-entry", "cur-size": 2048, "max-size": 21504 }= , > + { "name": "that-entry", "cur-size": 1024, "max-size": 21504 }= , > + { "name": "other-entry", "cur-size": 4096, "max-size": 41472 = } ] > + } ] > + } Looks reasonable. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2GJCQMMQIJOQRUSXSXQSF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRnljwAAoJEKeha0olJ0Nqs4AH/jXuJDU4WXJP71sKGJdBSn0o 6EiCVyVMmo4/JYzNcFj6+l203FdP1GFkiixBPTAmbtnoc+KNdNJYbC+wCA8BWCc0 gJxS9w6PdVwA+CW4wqV3Ipz9eSt8MmEBIkyGfeNQuL1/k1qyNL6aZOjG3Xao2lHv pZxyRsTJKFlsL78wKwQL+KohkBuo2ui5iJpdavf0HNCbaNd8cILJmDHYwBkPJA7q YuLFBplM3fm0kYv/BfcUTHZID7P/JVYti6YM/0I/CmAQemY1ABW7FobHI2f20UxP pXk35egucbl5sNkc3idL0vB64VcJdqLZkYITzAb/3iBSLNn2xIEqG5aQsJtgDKU= =jbs4 -----END PGP SIGNATURE----- ------enig2GJCQMMQIJOQRUSXSXQSF--