From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56271) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfaTi-0001Sw-G1 for qemu-devel@nongnu.org; Thu, 23 May 2013 14:43:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UfaTh-0002sa-8n for qemu-devel@nongnu.org; Thu, 23 May 2013 14:43:06 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:34658) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfaTh-0002sT-2C for qemu-devel@nongnu.org; Thu, 23 May 2013 14:43:05 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 23 May 2013 12:43:04 -0600 Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 2702D6E8048 for ; Thu, 23 May 2013 14:42:59 -0400 (EDT) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r4NIh2AA43057162 for ; Thu, 23 May 2013 14:43:02 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r4NIh2Qw011190 for ; Thu, 23 May 2013 14:43:02 -0400 Message-ID: <519E6335.7040101@linux.vnet.ibm.com> Date: Thu, 23 May 2013 14:43:01 -0400 From: Corey Bryant MIME-Version: 1.0 References: <1369331087-22345-1-git-send-email-coreyb@linux.vnet.ibm.com> <1369331087-22345-8-git-send-email-coreyb@linux.vnet.ibm.com> <519E58F0.5030809@redhat.com> In-Reply-To: <519E58F0.5030809@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 7/7] monitor: QMP/HMP support for retrieving VNVRAM details List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanb@linux.vnet.ibm.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com, jschopp@linux.vnet.ibm.com, stefanha@redhat.com On 05/23/2013 01:59 PM, Eric Blake wrote: > On 05/23/2013 11:44 AM, Corey Bryant wrote: >> Signed-off-by: Corey Bryant >> --- > > Might help to list a sample HMP or QMP usage in the commit message. > >> +++ b/qapi-schema.json >> @@ -3619,3 +3619,50 @@ >> '*cpuid-input-ecx': 'int', >> 'cpuid-register': 'X86CPURegister32', >> 'features': 'int' } } >> + >> +# @VNVRAMEntryInfo: >> +# >> +# Information about an entry in the VNVRAM. >> +# >> +# @name: name of the entry >> +# >> +# @cur-size: current size of the entry's blob in bytes >> +# >> +# @max-size: max size of the entry's blob in bytes >> +# >> +# Since: 1.6 >> +# >> +## >> +{ 'type': 'VNVRAMEntryInfo', >> + 'data': {'name': 'str', 'cur-size': 'int', 'max-size': 'int', } } > > No trailing commas in JSON. :( > I'll fix that. >> + >> +## >> +# @VNVRAMInfo: >> +# >> +# Information about the VNVRAM device. >> +# >> +# @drive-id: ID of the VNVRAM (and associated drive) >> +# >> +# @virtual-disk-size: Virtual size of the associated disk drive in bytes >> +# >> +# @vnvram-size: Size of the VNVRAM in bytes >> +# >> +# @entries: Array of @VNVRAMEntryInfo >> +# >> +# Since: 1.6 >> +# >> +## >> +{ 'type': 'VNVRAMInfo', >> + 'data': {'drive-id': 'str', 'virtual-disk-size': 'int', >> + 'vnvram-size': 'int', 'entries' : ['VNVRAMEntryInfo']} } >> + >> +## >> +# @query-vnvram: >> +# >> +# Return information about the VNVRAM devices. >> +# >> +# Returns: @VNVRAMInfo on success >> +# >> +# Since: 1.6 >> +## >> +{ 'command': 'query-vnvram', 'returns': ['VNVRAMInfo'] } > > Other than that, this looks fine from an interface point of view. I > haven't closely reviewed code, though. > >> + >> +Example: >> + >> +-> { "execute": "query-vnvram" } >> +<- {"return": [ >> + { "vnvram-size": 2050, "virtual-disk-size": 2000896, >> + "drive-id": "drive-ide0-0-0", >> + "entries": [ >> + { "name": "this-entry", "cur-size": 2048, "max-size": 21504 }, >> + { "name": "that-entry", "cur-size": 1024, "max-size": 21504 }, >> + { "name": "other-entry", "cur-size": 4096, "max-size": 41472 } ] >> + } ] >> + } > > Looks reasonable. > Thanks for the review! -- Regards, Corey Bryant