From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41611)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Ufb83-0003Fk-0F
	for qemu-devel@nongnu.org; Thu, 23 May 2013 15:24:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Ufb7x-0002Z5-G1
	for qemu-devel@nongnu.org; Thu, 23 May 2013 15:24:46 -0400
Received: from mail-ee0-f51.google.com ([74.125.83.51]:55799)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Ufb7x-0002Z0-AC
	for qemu-devel@nongnu.org; Thu, 23 May 2013 15:24:41 -0400
Received: by mail-ee0-f51.google.com with SMTP id e51so2097433eek.10
	for <qemu-devel@nongnu.org>; Thu, 23 May 2013 12:24:40 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <519E6CEE.1080201@redhat.com>
Date: Thu, 23 May 2013 21:24:30 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1369133851-1894-1-git-send-email-pbonzini@redhat.com>
	<1369133851-1894-22-git-send-email-pbonzini@redhat.com>
	<CAFEAcA8w_WbPTqEcVSK2BCn2dTZ_bSFUcBsVp9QrFaK1DVY1yw@mail.gmail.com>
In-Reply-To: <CAFEAcA8w_WbPTqEcVSK2BCn2dTZ_bSFUcBsVp9QrFaK1DVY1yw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 21/30] memory: Add iommu map/unmap notifiers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: David Gibson <david@gibson.dropbear.id.au>, qemu-devel@nongnu.org, jan.kiszka@gmail.com

Il 23/05/2013 20:27, Peter Maydell ha scritto:
> On 21 May 2013 11:57, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> From: David Gibson <david@gibson.dropbear.id.au>
>>
>> This patch adds a NotifierList to MemoryRegions which represent IOMMUs
>> allowing other parts of the code to register interest in mappings or
>> unmappings from the IOMMU.  All IOMMU implementations will need to call
>> memory_region_notify_iommu() to inform those waiting on the notifier list,
>> whenever an IOMMU mapping is made or removed.
>>
>> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
>> @@ -423,6 +425,11 @@ static inline bool memory_region_is_romd(MemoryRegion *mr)
>>   */
>>  bool memory_region_is_iommu(MemoryRegion *mr);
>>
>> +void memory_region_notify_iommu(MemoryRegion *mr,
>> +                                IOMMUTLBEntry entry);
>> +void memory_region_register_iommu_notifier(MemoryRegion *mr, Notifier *n);
>> +void memory_region_unregister_iommu_notifier(Notifier *n);
> 
> These all need doc comments.

David, can you provide them?  (If not as a patch, just an inline reply
to this email will do).

Paolo