From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfmxC-0004W9-HD for qemu-devel@nongnu.org; Fri, 24 May 2013 04:02:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ufmx7-0006IS-P8 for qemu-devel@nongnu.org; Fri, 24 May 2013 04:02:22 -0400 Received: from mail-ee0-f48.google.com ([74.125.83.48]:41174) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ufmx7-0006I6-Hp for qemu-devel@nongnu.org; Fri, 24 May 2013 04:02:17 -0400 Received: by mail-ee0-f48.google.com with SMTP id b47so2302525eek.7 for ; Fri, 24 May 2013 01:02:16 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <519F1E7E.7050700@redhat.com> Date: Fri, 24 May 2013 10:02:06 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1369133851-1894-1-git-send-email-pbonzini@redhat.com> <1369133851-1894-16-git-send-email-pbonzini@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 15/30] memory: add address_space_valid List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: David Gibson , qemu-devel@nongnu.org, jan.kiszka@gmail.com Il 23/05/2013 20:04, Peter Maydell ha scritto: > Shouldn't we be calling the MemoryRegionOps > accepts() callback here? What about access alignment constraints > and access size restrictions? Yes, we should. > What if the validity of the range > changes between the time you asked and when you actually do the > access? If that's a concern, you shouldn't use this API, you should just do the access and rely on the return value of address_space_rw & friends. (Or, at least for the foreseeable future, do the checks under the BQL). Paolo