From: "Andreas Färber" <afaerber@suse.de>
To: liguang <lig.fnst@cn.fujitsu.com>
Cc: peter.maydell@linaro.org, ehabkost@redhat.com,
qemu-devel@nongnu.org, blauwirbel@gmail.com, pbonzini@redhat.com,
imammedo@redhat.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [update][PATCH 00/12] target-i386: remove some macros
Date: Fri, 24 May 2013 13:37:43 +0200 [thread overview]
Message-ID: <519F5107.1060200@suse.de> (raw)
In-Reply-To: <1366705016-30471-1-git-send-email-lig.fnst@cn.fujitsu.com>
Am 23.04.2013 10:16, schrieb liguang:
> remove macros EAX, EBX, ECX, EDX, EBP, ESP, ESI, EDI, EIP, DF
> as suggested by Richard Henderson <rth@twiddle.net>
>
> Li Guang (12)
> target-i386/helper: remove EAX macro
> target-i386/helper: remove EBX macro
> target-i386/helper: remove ECX macro
> target-i386/helper: remove EDX macro
> target-i386/helper: remove EBP macro
> target-i386/helper: remove ESP macro
> target-i386/helper: remove ESI macro
> target-i386/helper: remove EDI macro
> target-i386/helper: remove EIP macro
> target-i386/helper: remove DF macro
> target-i386/helper: remove redundant env->eip assignment
> target-i386: fix over 80 chars warnings
Hard Freeze is over, so more time to look into refactorings:
There's one thing to be aware of here, macros would make it easier to
transition from CPUX86State to X86CPU fields. However I am guessing that
all these registers are accessed by TCG code via offsets from cpu_env -
please verify that. If so,
Reviewed-by: Andreas Färber <afaerber@suse.de>
However, it would be nice if you could fix the \ alignment in patch
06/12 or in the cleanup patch 12/12.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-05-24 11:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 8:16 [Qemu-devel] [update][PATCH 00/12] target-i386: remove some macros liguang
2013-04-23 8:16 ` [Qemu-devel] [update][PATCH 01/12] target-i386/helper: remove EAX macro liguang
2013-04-23 8:16 ` [Qemu-devel] [update][PATCH 02/12] target-i386/helper: remove EBX macro liguang
2013-04-23 8:16 ` [Qemu-devel] [update][PATCH 03/12] target-i386/helper: remove ECX macro liguang
2013-04-23 8:16 ` [Qemu-devel] [update][PATCH 04/12] target-i386/helper: remove EDX macro liguang
2013-04-23 8:16 ` [Qemu-devel] [update][PATCH 05/12] target-i386/helper: remove EBP macro liguang
2013-04-23 8:16 ` [Qemu-devel] [update][PATCH 06/12] target-i386/helper: remove ESP macro liguang
2013-04-23 8:16 ` [Qemu-devel] [update][PATCH 07/12] target-i386/helper: remove ESI macro liguang
2013-04-23 8:16 ` [Qemu-devel] [update][PATCH 08/12] target-i386/helper: remove EDI macro liguang
2013-04-23 8:16 ` [Qemu-devel] [update][PATCH 09/12] target-i386/helper: remove EIP macro liguang
2013-04-23 8:16 ` [Qemu-devel] [update][PATCH 10/12] target-i386/helper: remove DF macro liguang
2013-04-23 8:16 ` [Qemu-devel] [update][PATCH 11/12] target-i386/helper: remove redundant env->eip assignment liguang
2013-04-23 8:16 ` [Qemu-devel] [update][PATCH 12/12] target-i386: fix over 80 chars warnings liguang
2013-05-08 5:43 ` [Qemu-devel] [update][PATCH 00/12] target-i386: remove some macros li guang
2013-05-08 13:48 ` Eduardo Habkost
2013-05-08 23:54 ` li guang
2013-05-24 2:52 ` li guang
2013-05-24 11:37 ` Andreas Färber [this message]
2013-05-26 15:55 ` Andreas Färber
2013-05-27 0:25 ` li guang
2013-05-28 2:11 ` li guang
2013-05-28 7:41 ` Andreas Färber
2013-05-28 7:48 ` li guang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519F5107.1060200@suse.de \
--to=afaerber@suse.de \
--cc=blauwirbel@gmail.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=lig.fnst@cn.fujitsu.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).