From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48047)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UfraP-0003I3-Nx
	for qemu-devel@nongnu.org; Fri, 24 May 2013 08:59:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UfraH-0003fq-SW
	for qemu-devel@nongnu.org; Fri, 24 May 2013 08:59:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:32778)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UfraH-0003fj-KV
	for qemu-devel@nongnu.org; Fri, 24 May 2013 08:59:01 -0400
Message-ID: <519F649D.6050405@redhat.com>
Date: Fri, 24 May 2013 15:01:17 +0200
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <20130521153333.4880.74390.stgit@hds.com>
	<20130521153341.4880.11812.stgit@hds.com>
In-Reply-To: <20130521153341.4880.11812.stgit@hds.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH v3 02/11] Fix errors and warnings while
 compiling with c++ compilier
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
Cc: mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, vrozenfe@redhat.com, pbonzini@redhat.com, seiji.aguchi@hds.com, areis@redhat.com

On 05/21/13 17:33, Tomoki Sekiyama wrote:

> diff --git a/scripts/qapi.py b/scripts/qapi.py
> index afc5f32..b174acb 100644
> --- a/scripts/qapi.py
> +++ b/scripts/qapi.py
> @@ -156,9 +156,16 @@ def c_var(name, protect=True):
>      # GCC http://gcc.gnu.org/onlinedocs/gcc-4.7.1/gcc/C-Extensions.html
>      # excluding _.*
>      gcc_words = set(['asm', 'typeof'])
> +    # C++ ISO/IEC 14882:2003 2.11
> +    cpp_words = set(['bool', 'catch', 'class', 'const_cast', 'delete',
> +                     'dynamic_cast', 'explicit', 'false', 'friend', 'mutable',
> +                     'namespace', 'new', 'operator', 'private', 'protected',
> +                     'public', 'reinterpret_cast', 'static_cast', 'template',
> +                     'this', 'throw', 'true', 'try', 'typeid', 'typename',
> +                     'using', 'virtual', 'wchar_t'])
>      # namespace pollution:
>      polluted_words = set(['unix'])
> -    if protect and (name in c89_words | c99_words | c11_words | gcc_words | polluted_words):
> +    if protect and (name in c89_words | c99_words | c11_words | gcc_words | cpp_words | polluted_words):
>          return "q_" + name
>      return name.replace('-', '_').lstrip("*")

Since you're respinning anyway, perhaps consider adding these lovely
"alternative representations" from just one paragraph below (they are
reserved and "shall not be used otherwise" than the operators they stand
for):

and	bitand	compl	not_eq	or_eq	xor_eq
and_eq	bitor	not	or	xor

although probably noone would use these as identifiers or otherwise...
So just mentioning it for completeness.

Laszlo