From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42642) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfsYR-0008QU-U3 for qemu-devel@nongnu.org; Fri, 24 May 2013 10:01:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UfsYK-0001RK-Hz for qemu-devel@nongnu.org; Fri, 24 May 2013 10:01:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10368) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfsYK-0001Qa-9N for qemu-devel@nongnu.org; Fri, 24 May 2013 10:01:04 -0400 Message-ID: <519F7328.1040409@redhat.com> Date: Fri, 24 May 2013 16:03:20 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <20130521153333.4880.74390.stgit@hds.com> <20130521153349.4880.13431.stgit@hds.com> In-Reply-To: <20130521153349.4880.13431.stgit@hds.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v3 04/11] qemu-ga: Add an configure option to specify path to Windows VSS SDK List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tomoki Sekiyama Cc: mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, vrozenfe@redhat.com, pbonzini@redhat.com, seiji.aguchi@hds.com, areis@redhat.com On 05/21/13 17:33, Tomoki Sekiyama wrote: > + if test "$vss_win32_sdk" != "" ; then > + echo "ERROR: Please download and install Microsoft VSS SDK:" > + echo "ERROR: http://www.microsoft.com/en-us/download/details.aspx?id=23490" > + echo "ERROR: On POSIX-systems, you can extract the SDK headers by:" > + echo "ERROR: scripts/extract-vsssdk-headers setup.exe" > + echo "ERROR: The headers are extracted in the directory \`inc'." > + feature_not_found "VSS support" > + fi Please consider adding >&2 after the "fi". (... although even feature_not_found() --> error_exit() misses that redirection (and the behavior would change with my suggestion), so maybe it's more consistent the way you submitted it.) Laszlo