From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:43925)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1Ug0na-0006Tf-NH
	for qemu-devel@nongnu.org; Fri, 24 May 2013 18:49:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1Ug0nU-00034O-95
	for qemu-devel@nongnu.org; Fri, 24 May 2013 18:49:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:24876)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1Ug0nU-00034J-1L
	for qemu-devel@nongnu.org; Fri, 24 May 2013 18:49:16 -0400
Message-ID: <519FEEEB.40004@redhat.com>
Date: Sat, 25 May 2013 00:51:23 +0200
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <20130508113924.GA7698@rox.home.comstyle.com>
In-Reply-To: <20130508113924.GA7698@rox.home.comstyle.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Remove OSS support for OpenBSD
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Brad Smith <brad@comstyle.com>
Cc: qemu-devel@nongnu.org

On 05/08/13 13:39, Brad Smith wrote:
> Remove the OSS support for OpenBSD. The OSS API has not been usable
> for quite some time.
> 
> Signed-off-by: Brad Smith <brad@comstyle.com>
> 
> diff --git a/audio/ossaudio.c b/audio/ossaudio.c
> index 00be9c9..007c641 100644
> --- a/audio/ossaudio.c
> +++ b/audio/ossaudio.c
> @@ -25,11 +25,7 @@
>  #include <sys/mman.h>
>  #include <sys/types.h>
>  #include <sys/ioctl.h>
> -#ifdef __OpenBSD__
> -#include <soundcard.h>
> -#else
>  #include <sys/soundcard.h>
> -#endif
>  #include "qemu-common.h"
>  #include "qemu/main-loop.h"
>  #include "qemu/host-utils.h"
> diff --git a/configure b/configure
> index 9439f1c..89dda5b 100755
> --- a/configure
> +++ b/configure
> @@ -468,8 +468,7 @@ OpenBSD)
>    bsd="yes"
>    make="${MAKE-gmake}"
>    audio_drv_list="oss"
> -  audio_possible_drivers="oss sdl esd"
> -  oss_lib="-lossaudio"
> +  audio_possible_drivers="sdl esd"
>  ;;
>  Darwin)
>    bsd="yes"
> 

Shouldn't the default audio driver list ($audio_drv_list) be a subset of
the possible driver list?

Thanks,
Laszlo