Re: [Qemu-devel] [PATCH V3 4/4] block: dump snapshot and image info to specified output

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1683 bytes --]

On 05/24/2013 09:09 PM, Wenchao Xia wrote:
> bdrv_snapshot_dump() and bdrv_image_info_dump() do not dump to a buffer now,
> some internal buffers are still used for format control, which have no
> chance to be truncated. As a result, these two functions have no more issue
> of truncation, and they can be used by both qemu and qemu-img with correct
> parameter specified.
> 
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
>  block/qapi.c         |   66 +++++++++++++++++++++++++++----------------------
>  include/block/qapi.h |    6 +++-
>  qemu-img.c           |    9 ++++---
>  savevm.c             |    7 +++--
>  4 files changed, 49 insertions(+), 39 deletions(-)

> -char *bdrv_snapshot_dump(char *buf, int buf_size, QEMUSnapshotInfo *sn)
> +void bdrv_snapshot_dump(fprintf_function func_fprintf, void *f,
> +                        QEMUSnapshotInfo *sn)
>  {
>      char buf1[128], date_buf[128], clock_buf[128];

> +        func_fprintf(f,
> +                     "%-10s%-20s%7s%20s%15s",
> +                     sn->id_str, sn->name,
> +                     get_human_readable_size(buf1, sizeof(buf1),
> +                                             sn->vm_state_size),
> +                     date_buf,
> +                     clock_buf);

Now that 'buf' is no longer in scope, it might be nice to rename 'buf1'
to something more meaningful; maybe size_buf to go along with the other
two named buffers.  But the choice of naming doesn't impact the
correctness, so

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]