From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UgDPp-0002Bb-SJ for qemu-devel@nongnu.org; Sat, 25 May 2013 08:17:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UgDPn-0007cJ-KR for qemu-devel@nongnu.org; Sat, 25 May 2013 08:17:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24888) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UgDPn-0007cC-BH for qemu-devel@nongnu.org; Sat, 25 May 2013 08:17:39 -0400 Message-ID: <51A0ABDE.1090707@redhat.com> Date: Sat, 25 May 2013 06:17:34 -0600 From: Eric Blake MIME-Version: 1.0 References: <1369451385-23452-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1369451385-23452-3-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1369451385-23452-3-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2XCGOSMTBLERVUROWGRBC" Subject: Re: [Qemu-devel] [PATCH V3 2/4] block: move snapshot code in block.c to block/snapshot.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, phrdina@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2XCGOSMTBLERVUROWGRBC Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/24/2013 09:09 PM, Wenchao Xia wrote: > All snapshot related code, except bdrv_snapshot_dump() and > bdrv_is_snapshot(), is moved to block/snapshot.c. bdrv_snapshot_dump() > will be moved to another file later. bdrv_is_snapshot() is not related > with internal snapshot. It also fixes small code style errors reported > by check script. >=20 > Signed-off-by: Wenchao Xia > --- > block.c | 100 ----------------------------- > block/Makefile.objs | 1 + > block/snapshot.c | 157 ++++++++++++++++++++++++++++++++++++++= ++++++++ > include/block/block.h | 26 ++------ > include/block/snapshot.h | 53 ++++++++++++++++ > savevm.c | 23 +------- > 6 files changed, 217 insertions(+), 143 deletions(-) > create mode 100644 block/snapshot.c > create mode 100644 include/block/snapshot.h Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2XCGOSMTBLERVUROWGRBC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRoKveAAoJEKeha0olJ0Nq7usIAJs7BPpx39eOF86XXZHKoDbd 926uT+5xJwHv7lZOpfSqb7/2kqeJuTR7vzfe5kPwi6WbciP51mwSt/ANJ6hkkYBr d5jRwHVsgmsdHVeFVuLhP8QB0AcJwf0oOacFAs/fZDeb1GnQoqDiSIspKS2cvpVG sz4fnZX7gkrpLikC5AEhaPhuJrB921+LEpXz4Fw5GOTan5kTZ0jJ/J+H5RKZ0+AF 9J+p9poOexfQDv6JYH1pncHsbYR4hHE69VGGFiUJPikjD2nKMkj1YF20Vr2xuhbN oUFIVatpwB699EKJjtMs4e2EZOFk6iKxDgu9BeiQjJC386GZWF79lLGzpvi3Trs= =lENA -----END PGP SIGNATURE----- ------enig2XCGOSMTBLERVUROWGRBC--