From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60081) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UgH3S-0001v7-J7 for qemu-devel@nongnu.org; Sat, 25 May 2013 12:10:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UgH3M-0001QX-Cn for qemu-devel@nongnu.org; Sat, 25 May 2013 12:10:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10494) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UgH3L-0001QJ-Q2 for qemu-devel@nongnu.org; Sat, 25 May 2013 12:10:44 -0400 Message-ID: <51A0E26A.7020703@redhat.com> Date: Sat, 25 May 2013 10:10:18 -0600 From: Eric Blake MIME-Version: 1.0 References: <1369455886-30677-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1369455886-30677-4-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1369455886-30677-4-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2OHJTDRMWOOIOJRDHCGMS" Subject: Re: [Qemu-devel] [PATCH V13 3/6] qmp: add recursive member in ImageInfo List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, phrdina@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2OHJTDRMWOOIOJRDHCGMS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/24/2013 10:24 PM, Wenchao Xia wrote: > New member *backing-image is added to reflect the backing chain > status. >=20 > Signed-off-by: Wenchao Xia > --- > block/qapi.c | 16 +++++++++++++++- > qapi-schema.json | 5 ++++- > 2 files changed, 19 insertions(+), 2 deletions(-) >=20 > diff --git a/block/qapi.c b/block/qapi.c > index 680ec23..cbef584 100644 > --- a/block/qapi.c > +++ b/block/qapi.c > @@ -88,7 +88,21 @@ int bdrv_query_snapshot_info_list(BlockDriverState *= bs, > return 0; > } > =20 > -/* @p_info will be set only on success. */ > +/** > + * bdrv_query_image_info: > + * @bs: block device to examine > + * @p_info: location to store image information > + * @errp: location to store error information > + * > + * Store "flat" image inforation in @p_info. s/inforation/information/ > + * > + * "Flat" means it does *not* query backing image information, > + * i.e. (*pinfo)->has_backing_image will be set to false and > + * (*pinfo)->backing_image to NULL even when the image does in fact ha= ve > + * a backing image. > + * > + * @p_info will be set only on success. On error, store error in @errp= =2E > + */ Does this comment hunk belong in the previous patch? > void bdrv_query_image_info(BlockDriverState *bs, > ImageInfo **p_info, > Error **errp) > diff --git a/qapi-schema.json b/qapi-schema.json > index ef1f657..a02999d 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -236,6 +236,8 @@ > # > # @snapshots: #optional list of VM snapshots > # > +# @backing-image: #optional info of the backing image (since 1.6) > +# > # Since: 1.3 > # > ## > @@ -245,7 +247,8 @@ > '*actual-size': 'int', 'virtual-size': 'int', > '*cluster-size': 'int', '*encrypted': 'bool', > '*backing-filename': 'str', '*full-backing-filename': 'str'= , > - '*backing-filename-format': 'str', '*snapshots': ['Snapshot= Info'] } } > + '*backing-filename-format': 'str', '*snapshots': ['Snapshot= Info'], > + '*backing-image': 'ImageInfo' } } The API change looks fine, except there is no code change to actually populate the new field. This hunk should probably be squashed with the patch that implements the field. Also, are you missing any changes to qmp-commands.hx? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2OHJTDRMWOOIOJRDHCGMS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRoOJqAAoJEKeha0olJ0NqtIsH/RiaLTw2gRt3o7UJPi/bm6ZV DO8N/40Ltpe47qV5wBU5/Rf4IvfgL0+JD1rdK6HCGceDQqVswrJNjLnToS9Epqe2 liYEjQid8f82Lq0u1/j32qb3zYBHTTIQwxl2MCYIodFf3PRGU6eNY0QdQQye1789 QAw8unlXAT3RgUKTquFfx2v3zwqYgxdcRRtSUOyaWvI2PR9AxLfNkJwGj69uPmJu b8cywVnIRKWyTNzkE77Cq6HFMeH5+SnFbuY5wcc9eZsXZGF3kgVFdqWjEnDVcZpY lLddxSKhY7cSn12iMYva2t1qQCjeFhrVB/vkzbRky152qRKlPdXCeu8TnwGIRN4= =vKA5 -----END PGP SIGNATURE----- ------enig2OHJTDRMWOOIOJRDHCGMS--