* [Qemu-devel] [PATCH] Remove OSS support for OpenBSD
@ 2013-05-24 23:01 Brad Smith
2013-05-24 23:50 ` Laszlo Ersek
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Brad Smith @ 2013-05-24 23:01 UTC (permalink / raw)
To: qemu-devel
Remove the OSS support for OpenBSD. The OSS API has not been usable
for quite some time.
Signed-off-by: Brad Smith <brad@comstyle.com>
diff --git a/audio/ossaudio.c b/audio/ossaudio.c
index 00be9c9..007c641 100644
--- a/audio/ossaudio.c
+++ b/audio/ossaudio.c
@@ -25,11 +25,7 @@
#include <sys/mman.h>
#include <sys/types.h>
#include <sys/ioctl.h>
-#ifdef __OpenBSD__
-#include <soundcard.h>
-#else
#include <sys/soundcard.h>
-#endif
#include "qemu-common.h"
#include "qemu/main-loop.h"
#include "qemu/host-utils.h"
diff --git a/configure b/configure
index 5ae7e4a..eb74510 100755
--- a/configure
+++ b/configure
@@ -468,9 +468,8 @@ NetBSD)
OpenBSD)
bsd="yes"
make="${MAKE-gmake}"
- audio_drv_list="oss"
- audio_possible_drivers="oss sdl esd"
- oss_lib="-lossaudio"
+ audio_drv_list="sdl"
+ audio_possible_drivers="sdl esd"
;;
Darwin)
bsd="yes"
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] Remove OSS support for OpenBSD
2013-05-24 23:01 [Qemu-devel] [PATCH] Remove OSS support for OpenBSD Brad Smith
@ 2013-05-24 23:50 ` Laszlo Ersek
2013-05-25 19:12 ` Andreas Färber
2013-05-26 17:04 ` Blue Swirl
2 siblings, 0 replies; 8+ messages in thread
From: Laszlo Ersek @ 2013-05-24 23:50 UTC (permalink / raw)
To: Brad Smith; +Cc: qemu-devel
On 05/25/13 01:01, Brad Smith wrote:
> Remove the OSS support for OpenBSD. The OSS API has not been usable
> for quite some time.
>
> Signed-off-by: Brad Smith <brad@comstyle.com>
>
>
> diff --git a/audio/ossaudio.c b/audio/ossaudio.c
> index 00be9c9..007c641 100644
> --- a/audio/ossaudio.c
> +++ b/audio/ossaudio.c
> @@ -25,11 +25,7 @@
> #include <sys/mman.h>
> #include <sys/types.h>
> #include <sys/ioctl.h>
> -#ifdef __OpenBSD__
> -#include <soundcard.h>
> -#else
> #include <sys/soundcard.h>
> -#endif
> #include "qemu-common.h"
> #include "qemu/main-loop.h"
> #include "qemu/host-utils.h"
> diff --git a/configure b/configure
> index 5ae7e4a..eb74510 100755
> --- a/configure
> +++ b/configure
> @@ -468,9 +468,8 @@ NetBSD)
> OpenBSD)
> bsd="yes"
> make="${MAKE-gmake}"
> - audio_drv_list="oss"
> - audio_possible_drivers="oss sdl esd"
> - oss_lib="-lossaudio"
> + audio_drv_list="sdl"
> + audio_possible_drivers="sdl esd"
> ;;
> Darwin)
> bsd="yes"
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] Remove OSS support for OpenBSD
2013-05-24 23:01 [Qemu-devel] [PATCH] Remove OSS support for OpenBSD Brad Smith
2013-05-24 23:50 ` Laszlo Ersek
@ 2013-05-25 19:12 ` Andreas Färber
2013-05-26 17:04 ` Blue Swirl
2 siblings, 0 replies; 8+ messages in thread
From: Andreas Färber @ 2013-05-25 19:12 UTC (permalink / raw)
To: Brad Smith; +Cc: qemu-trivial, qemu-devel
Am 25.05.2013 01:01, schrieb Brad Smith:
> Remove the OSS support for OpenBSD. The OSS API has not been usable
> for quite some time.
>
> Signed-off-by: Brad Smith <brad@comstyle.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
CC'ing qemu-trivial.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] Remove OSS support for OpenBSD
2013-05-24 23:01 [Qemu-devel] [PATCH] Remove OSS support for OpenBSD Brad Smith
2013-05-24 23:50 ` Laszlo Ersek
2013-05-25 19:12 ` Andreas Färber
@ 2013-05-26 17:04 ` Blue Swirl
2 siblings, 0 replies; 8+ messages in thread
From: Blue Swirl @ 2013-05-26 17:04 UTC (permalink / raw)
To: Brad Smith; +Cc: qemu-devel
On Fri, May 24, 2013 at 11:01 PM, Brad Smith <brad@comstyle.com> wrote:
> Remove the OSS support for OpenBSD. The OSS API has not been usable
> for quite some time.
>
> Signed-off-by: Brad Smith <brad@comstyle.com>
Thanks, applied.
>
>
> diff --git a/audio/ossaudio.c b/audio/ossaudio.c
> index 00be9c9..007c641 100644
> --- a/audio/ossaudio.c
> +++ b/audio/ossaudio.c
> @@ -25,11 +25,7 @@
> #include <sys/mman.h>
> #include <sys/types.h>
> #include <sys/ioctl.h>
> -#ifdef __OpenBSD__
> -#include <soundcard.h>
> -#else
> #include <sys/soundcard.h>
> -#endif
> #include "qemu-common.h"
> #include "qemu/main-loop.h"
> #include "qemu/host-utils.h"
> diff --git a/configure b/configure
> index 5ae7e4a..eb74510 100755
> --- a/configure
> +++ b/configure
> @@ -468,9 +468,8 @@ NetBSD)
> OpenBSD)
> bsd="yes"
> make="${MAKE-gmake}"
> - audio_drv_list="oss"
> - audio_possible_drivers="oss sdl esd"
> - oss_lib="-lossaudio"
> + audio_drv_list="sdl"
> + audio_possible_drivers="sdl esd"
> ;;
> Darwin)
> bsd="yes"
>
> --
> This message has been scanned for viruses and
> dangerous content by MailScanner, and is
> believed to be clean.
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Qemu-devel] [PATCH] Remove OSS support for OpenBSD
@ 2013-05-08 11:39 Brad Smith
2013-05-24 22:16 ` Brad Smith
2013-05-24 22:51 ` Laszlo Ersek
0 siblings, 2 replies; 8+ messages in thread
From: Brad Smith @ 2013-05-08 11:39 UTC (permalink / raw)
To: qemu-devel
Remove the OSS support for OpenBSD. The OSS API has not been usable
for quite some time.
Signed-off-by: Brad Smith <brad@comstyle.com>
diff --git a/audio/ossaudio.c b/audio/ossaudio.c
index 00be9c9..007c641 100644
--- a/audio/ossaudio.c
+++ b/audio/ossaudio.c
@@ -25,11 +25,7 @@
#include <sys/mman.h>
#include <sys/types.h>
#include <sys/ioctl.h>
-#ifdef __OpenBSD__
-#include <soundcard.h>
-#else
#include <sys/soundcard.h>
-#endif
#include "qemu-common.h"
#include "qemu/main-loop.h"
#include "qemu/host-utils.h"
diff --git a/configure b/configure
index 9439f1c..89dda5b 100755
--- a/configure
+++ b/configure
@@ -468,8 +468,7 @@ OpenBSD)
bsd="yes"
make="${MAKE-gmake}"
audio_drv_list="oss"
- audio_possible_drivers="oss sdl esd"
- oss_lib="-lossaudio"
+ audio_possible_drivers="sdl esd"
;;
Darwin)
bsd="yes"
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] Remove OSS support for OpenBSD
2013-05-08 11:39 Brad Smith
@ 2013-05-24 22:16 ` Brad Smith
2013-05-24 22:51 ` Laszlo Ersek
1 sibling, 0 replies; 8+ messages in thread
From: Brad Smith @ 2013-05-24 22:16 UTC (permalink / raw)
To: qemu-devel
On Wed, May 08, 2013 at 07:39:25AM -0400, Brad Smith wrote:
> Remove the OSS support for OpenBSD. The OSS API has not been usable
> for quite some time.
>
> Signed-off-by: Brad Smith <brad@comstyle.com>
ping.
> diff --git a/audio/ossaudio.c b/audio/ossaudio.c
> index 00be9c9..007c641 100644
> --- a/audio/ossaudio.c
> +++ b/audio/ossaudio.c
> @@ -25,11 +25,7 @@
> #include <sys/mman.h>
> #include <sys/types.h>
> #include <sys/ioctl.h>
> -#ifdef __OpenBSD__
> -#include <soundcard.h>
> -#else
> #include <sys/soundcard.h>
> -#endif
> #include "qemu-common.h"
> #include "qemu/main-loop.h"
> #include "qemu/host-utils.h"
> diff --git a/configure b/configure
> index 9439f1c..89dda5b 100755
> --- a/configure
> +++ b/configure
> @@ -468,8 +468,7 @@ OpenBSD)
> bsd="yes"
> make="${MAKE-gmake}"
> audio_drv_list="oss"
> - audio_possible_drivers="oss sdl esd"
> - oss_lib="-lossaudio"
> + audio_possible_drivers="sdl esd"
> ;;
> Darwin)
> bsd="yes"
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] Remove OSS support for OpenBSD
2013-05-08 11:39 Brad Smith
2013-05-24 22:16 ` Brad Smith
@ 2013-05-24 22:51 ` Laszlo Ersek
2013-05-24 23:01 ` Brad Smith
1 sibling, 1 reply; 8+ messages in thread
From: Laszlo Ersek @ 2013-05-24 22:51 UTC (permalink / raw)
To: Brad Smith; +Cc: qemu-devel
On 05/08/13 13:39, Brad Smith wrote:
> Remove the OSS support for OpenBSD. The OSS API has not been usable
> for quite some time.
>
> Signed-off-by: Brad Smith <brad@comstyle.com>
>
> diff --git a/audio/ossaudio.c b/audio/ossaudio.c
> index 00be9c9..007c641 100644
> --- a/audio/ossaudio.c
> +++ b/audio/ossaudio.c
> @@ -25,11 +25,7 @@
> #include <sys/mman.h>
> #include <sys/types.h>
> #include <sys/ioctl.h>
> -#ifdef __OpenBSD__
> -#include <soundcard.h>
> -#else
> #include <sys/soundcard.h>
> -#endif
> #include "qemu-common.h"
> #include "qemu/main-loop.h"
> #include "qemu/host-utils.h"
> diff --git a/configure b/configure
> index 9439f1c..89dda5b 100755
> --- a/configure
> +++ b/configure
> @@ -468,8 +468,7 @@ OpenBSD)
> bsd="yes"
> make="${MAKE-gmake}"
> audio_drv_list="oss"
> - audio_possible_drivers="oss sdl esd"
> - oss_lib="-lossaudio"
> + audio_possible_drivers="sdl esd"
> ;;
> Darwin)
> bsd="yes"
>
Shouldn't the default audio driver list ($audio_drv_list) be a subset of
the possible driver list?
Thanks,
Laszlo
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] Remove OSS support for OpenBSD
2013-05-24 22:51 ` Laszlo Ersek
@ 2013-05-24 23:01 ` Brad Smith
0 siblings, 0 replies; 8+ messages in thread
From: Brad Smith @ 2013-05-24 23:01 UTC (permalink / raw)
To: Laszlo Ersek; +Cc: qemu-devel
On Sat, May 25, 2013 at 12:51:23AM +0200, Laszlo Ersek wrote:
> On 05/08/13 13:39, Brad Smith wrote:
> > Remove the OSS support for OpenBSD. The OSS API has not been usable
> > for quite some time.
> >
> > Signed-off-by: Brad Smith <brad@comstyle.com>
> >
> > diff --git a/audio/ossaudio.c b/audio/ossaudio.c
> > index 00be9c9..007c641 100644
> > --- a/audio/ossaudio.c
> > +++ b/audio/ossaudio.c
> > @@ -25,11 +25,7 @@
> > #include <sys/mman.h>
> > #include <sys/types.h>
> > #include <sys/ioctl.h>
> > -#ifdef __OpenBSD__
> > -#include <soundcard.h>
> > -#else
> > #include <sys/soundcard.h>
> > -#endif
> > #include "qemu-common.h"
> > #include "qemu/main-loop.h"
> > #include "qemu/host-utils.h"
> > diff --git a/configure b/configure
> > index 9439f1c..89dda5b 100755
> > --- a/configure
> > +++ b/configure
> > @@ -468,8 +468,7 @@ OpenBSD)
> > bsd="yes"
> > make="${MAKE-gmake}"
> > audio_drv_list="oss"
> > - audio_possible_drivers="oss sdl esd"
> > - oss_lib="-lossaudio"
> > + audio_possible_drivers="sdl esd"
> > ;;
> > Darwin)
> > bsd="yes"
> >
>
> Shouldn't the default audio driver list ($audio_drv_list) be a subset of
> the possible driver list?
My mistake. A new patch sent.
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-05-26 17:04 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-24 23:01 [Qemu-devel] [PATCH] Remove OSS support for OpenBSD Brad Smith
2013-05-24 23:50 ` Laszlo Ersek
2013-05-25 19:12 ` Andreas Färber
2013-05-26 17:04 ` Blue Swirl
-- strict thread matches above, loose matches on Subject: below --
2013-05-08 11:39 Brad Smith
2013-05-24 22:16 ` Brad Smith
2013-05-24 22:51 ` Laszlo Ersek
2013-05-24 23:01 ` Brad Smith
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).