From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56470) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UgWkg-0000W2-CN for qemu-devel@nongnu.org; Sun, 26 May 2013 04:56:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UgWke-0007V9-Qo for qemu-devel@nongnu.org; Sun, 26 May 2013 04:56:30 -0400 Received: from mail-ee0-f51.google.com ([74.125.83.51]:44299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UgWke-0007V5-Ke for qemu-devel@nongnu.org; Sun, 26 May 2013 04:56:28 -0400 Received: by mail-ee0-f51.google.com with SMTP id e51so3424012eek.38 for ; Sun, 26 May 2013 01:56:27 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <51A1CE2F.5050508@redhat.com> Date: Sun, 26 May 2013 10:56:15 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1369133851-1894-1-git-send-email-pbonzini@redhat.com> <1369133851-1894-18-git-send-email-pbonzini@redhat.com> <51A05CDF.1090106@web.de> <51A06C9B.5060302@redhat.com> <51A09018.7000901@web.de> <51A09E6F.7030109@redhat.com> <51A0A0D5.5000706@web.de> In-Reply-To: <51A0A0D5.5000706@web.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 17/30] memory: add address_space_translate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, David Gibson -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Il 25/05/2013 13:30, Jan Kiszka ha scritto: > On 2013-05-25 13:20, Paolo Bonzini wrote: >> Il 25/05/2013 12:19, Jan Kiszka ha scritto: >>> addr -= section->offset_within_address_space; - len = >>> MIN(section->size - addr, len); >> ^^^^^^^^^^^^^ ^^^^ >> >> This is the size of a section minus an offset in the section. >> >>> + diff = int128_sub(section->mr->size, >>> int128_make64(addr)); >> ^^^^^^^^^^^^^^^^^ ^^^^ >> >> This is the size of a region minus the same offset in the >> section. >> >>> + len = MIN(int128_get64(diff), len); >>> >>> /* Compute offset within MemoryRegion */ addr += >>> section->offset_within_region; >> >> So this has to be moved above. > > Right, fixed. > >> Do you have a branch pushed somewhere that I can test against? > > git://git.kiszka.org/qemu.git queues/ioport Nice patches. Only one thing, how is .impl.unaligned different from the existing .valid.unaligned? Paolo -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRoc4vAAoJEBvWZb6bTYby7UEP/0l5Stow6nrKirryCNuds3ky L3FTjqEhLZ+aKha4rdbYNKhwbvY92rfR/Wo8hMckkFv6wwcieHD+nYQltuIDW3y2 xV7FmCPJd1M1pajIQ5Nk+Ssqf7Qhv7jRX5Kg2L6ksNf5srb5485J9oH4M9hIO6CH XFHO9GeKmynbeeZmSNFF9mNlQd0leHx6h6IbJxYov/eD0zxp5cxoN7xM6+V5hCP/ UjBa2Zn07AI94BS/64YSHSa155BLxIOS5jJi25PNOWti29wHE8Nhw2KF5pMD/JYM hPblsTIpFf6zg53FMHmrY/B990Ol+IjNogQhRh3tSfNf/48XWA4l+anLdaMweQf6 TuCEOoDqgNphz6c5lOPjzQB/CJZFUCQzxaUjok499ZQyPY5SpIgjKmzl7Vszos8I wnYmJJ3xVLyJujvx61rg7qiW3ckyVx0sPHZXt/DWEDUNDHTW+HdqAcrZ8TgJrIni gQF1VEKNplxdgauIv17RGxnVOXwb8PcoNwXE9Gn6XJ/KKQLh9KukmdufCSBmOARV iiAo8N4rUK8FaCFXDwrZ3S8OIiyWCSdnud/4wZPcsI+r5gM/rrtlrZoQExyx5meO 9RzLBtL5hwFaQ9erE8ce+GDKbo+nie593z3UiN5NKLuH5KjWig2OYQxV6ylg4Vx7 RscCNjGvppk+2I3PAv9R =pCeD -----END PGP SIGNATURE-----