From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ugbj0-0001Ym-N0 for qemu-devel@nongnu.org; Sun, 26 May 2013 10:15:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ugbiy-00025m-Sc for qemu-devel@nongnu.org; Sun, 26 May 2013 10:15:06 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53241 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ugbiy-00023C-KB for qemu-devel@nongnu.org; Sun, 26 May 2013 10:15:04 -0400 Message-ID: <51A218DF.2070506@suse.de> Date: Sun, 26 May 2013 16:14:55 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1369414987-8839-1-git-send-email-pbonzini@redhat.com> <1369414987-8839-13-git-send-email-pbonzini@redhat.com> In-Reply-To: <1369414987-8839-13-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 12/15] s390x: reduce TARGET_PHYS_ADDR_SPACE_BITS to 62 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Christian Borntraeger , qemu-devel@nongnu.org, Avi Kivity , Alexander Graf Am 24.05.2013 19:03, schrieb Paolo Bonzini: > With the next patch, the memory API will complain if the > TARGET_PHYS_ADDR_SPACE_BITS gets dangerously close to an > overflow. s390x can handle up to 64 bit of physical address > space from its page tables, but we never use that much. Just > decrease the value. >=20 > Cc: Alexander Graf > Signed-off-by: Paolo Bonzini Didn't Avi introduce 128-bit arithmetic into QEMU to avoid 64-bit values overflowing? Why are you limiting Memory API to 62-bit now? Andreas > --- > target-s390x/cpu.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/target-s390x/cpu.h b/target-s390x/cpu.h > index 0ce82cf..6304c4d 100644 > --- a/target-s390x/cpu.h > +++ b/target-s390x/cpu.h > @@ -34,7 +34,10 @@ > #include "exec/cpu-defs.h" > #define TARGET_PAGE_BITS 12 > =20 > -#define TARGET_PHYS_ADDR_SPACE_BITS 64 > +/* Actually 64-bits, limited by the memory API to 62 bits. We > + * never use that much. > + */ > +#define TARGET_PHYS_ADDR_SPACE_BITS 62 > #define TARGET_VIRT_ADDR_SPACE_BITS 64 > =20 > #include "exec/cpu-all.h" >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg