From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52140) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ugg4k-0001ed-Fd for qemu-devel@nongnu.org; Sun, 26 May 2013 14:53:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ugg4c-00068N-Vw for qemu-devel@nongnu.org; Sun, 26 May 2013 14:53:50 -0400 Received: from mail-ee0-f53.google.com ([74.125.83.53]:44068) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ugg4c-000686-Q7 for qemu-devel@nongnu.org; Sun, 26 May 2013 14:53:42 -0400 Received: by mail-ee0-f53.google.com with SMTP id c1so3554109eek.12 for ; Sun, 26 May 2013 11:53:42 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <51A25A2D.8030700@redhat.com> Date: Sun, 26 May 2013 20:53:33 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1369581694-1655-1-git-send-email-mst@redhat.com> <20130526175110.GA3115@redhat.com> <20130526181017.GB3115@redhat.com> <51A253C6.7060303@redhat.com> <20130526183747.GB3427@redhat.com> In-Reply-To: <20130526183747.GB3427@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Peter Maydell , qemu-devel@nongnu.org Il 26/05/2013 20:37, Michael S. Tsirkin ha scritto: >> > I don't like defining __-prefixed types. Can we preprocess >> > linux-headers to avoid usage of __u8/16/32/64, and to >> > s,linux/types.h,stdint.h, ? >> > >> > Paolo > Let's not be purists, and do the practical thing. > > When I suggested this you didn't like it: >>> >> I can think of two ways: >>> >> - strip linux/types.h in update_headers >>> >> - add a stub linux/types.h for non linux platforms >> > >> >The latter, using stdint.h types, would be fine. My fault. I should have looked at linux/types.h (actually asm-generic/). Paolo