From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47920)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UglGf-0001Cq-RI
	for qemu-devel@nongnu.org; Sun, 26 May 2013 20:26:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UglGc-0002rB-7I
	for qemu-devel@nongnu.org; Sun, 26 May 2013 20:26:29 -0400
Message-ID: <51A2A8BF.9090101@redhat.com>
Date: Mon, 27 May 2013 02:28:47 +0200
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1369575248-31854-1-git-send-email-afaerber@suse.de>
	<51A2A4B6.2030400@redhat.com> <51A2A68B.9090703@suse.de>
In-Reply-To: <51A2A68B.9090703@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH stable-1.1] qga: set umask 0077 when
	daemonizing (CVE-2013-2007)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, qemu-stable@nongnu.org

On 05/27/13 02:19, Andreas F=C3=A4rber wrote:
> Am 27.05.2013 02:11, schrieb Laszlo Ersek:

>> Do you plan to backport
>>
>>   8fe6bbc qga: distinguish binary modes in "guest_file_open_modes" map
>>   2b72001 qga: unlink just created guest-file if fchmod() or fdopen()
>>           fails on it
>>
>> too? These are considered polish for the CVE fix.
>=20
> I did backport both to openSUSE 12.2 - they apply without conflicts. :)
> I mainly posted this one to check if there are better QERRs to use.

I think your choices were apt.

>> Also, a side-note: existing world-writable log files etc. are not
>> recreated nor have their modes changed, so maybe a release note or som=
e
>> such would be useful for admins ("delete your previous logfile &
>> optional unix domain socket, or change their modes manually").
>=20
> Feel free to add a note to the 1.5 Release Notes - it can then be copie=
d
> to the previous releases we backport this fix to.

Do you mean in the wiki? I'll need an account first :)

Thanks,
Laszlo