From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53799)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UgqzR-0001xO-N5
	for qemu-devel@nongnu.org; Mon, 27 May 2013 02:33:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UgqzM-0003jk-SV
	for qemu-devel@nongnu.org; Mon, 27 May 2013 02:33:05 -0400
Received: from mail-ee0-f45.google.com ([74.125.83.45]:54137)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UgqzM-0003jg-M2
	for qemu-devel@nongnu.org; Mon, 27 May 2013 02:33:00 -0400
Received: by mail-ee0-f45.google.com with SMTP id l10so3871942eei.32
	for <qemu-devel@nongnu.org>; Sun, 26 May 2013 23:32:59 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <51A2FE14.2050501@redhat.com>
Date: Mon, 27 May 2013 08:32:52 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1369621146-17095-1-git-send-email-alevy@redhat.com>
In-Reply-To: <1369621146-17095-1-git-send-email-alevy@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC] Add a stp file for usage from build directory
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org

Il 27/05/2013 04:19, Alon Levy ha scritto:
> For systemtap the location of the process being tapped is crucial, so
> the existing stp file requires installation to use. A new file providing
> qemu.local prefixed probes lets scripts run without an install step.
> 
> Signed-off-by: Alon Levy <alevy@redhat.com>
> ---
> 
>  Makefile.target | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/Makefile.target b/Makefile.target
> index ce4391f..5d176e2 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -35,7 +35,7 @@ config-target.h: config-target.h-timestamp
>  config-target.h-timestamp: config-target.mak
>  
>  ifdef CONFIG_TRACE_SYSTEMTAP
> -stap: $(QEMU_PROG).stp
> +stap: $(QEMU_PROG).stp $(QEMU_PROG).local.stp
>  
>  ifdef CONFIG_USER_ONLY
>  TARGET_TYPE=user
> @@ -51,6 +51,17 @@ $(QEMU_PROG).stp: $(SRC_PATH)/trace-events
>  		--target-arch=$(TARGET_ARCH) \
>  		--target-type=$(TARGET_TYPE) \
>  		< $< > $@,"  GEN   $(TARGET_DIR)$(QEMU_PROG).stp")
> +
> +$(QEMU_PROG).local.stp: $(SRC_PATH)/trace-events
> +	$(call quiet-command,$(TRACETOOL) \
> +		--format=stap \
> +		--backend=$(TRACE_BACKEND) \
> +		--binary=$(SRC_PATH)/$(TARGET_DIR)$(QEMU_PROG) \

This is not the build directory for out-of-tree builds.

> +		--probe-prefix=qemu.local \

Why change the prefix?

Paolo

> +		--target-arch=$(TARGET_ARCH) \
> +		--target-type=$(TARGET_TYPE) \
> +		< $< > $@,"  GEN   $(TARGET_DIR)$(QEMU_PROG).local.stp")
> +
>  else
>  stap:
>  endif
>