From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59864) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UgrSi-0001NR-LO for qemu-devel@nongnu.org; Mon, 27 May 2013 03:03:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UgrSc-0004Dq-Bt for qemu-devel@nongnu.org; Mon, 27 May 2013 03:03:20 -0400 Sender: Paolo Bonzini Message-ID: <51A30528.9020708@redhat.com> Date: Mon, 27 May 2013 09:03:04 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1367545092-19980-1-git-send-email-david@gibson.dropbear.id.au> <1367545092-19980-8-git-send-email-david@gibson.dropbear.id.au> <51875DA7.4090308@redhat.com> <51A301AC.8070101@ozlabs.ru> In-Reply-To: <51A301AC.8070101@ozlabs.ru> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: agraf@suse.de, David Gibson , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, quintela@redhat.com Il 27/05/2013 08:48, Alexey Kardashevskiy ha scritto: >> > >> > This is only true when the rerror and werror options have the values >> > "ignore" or "report". See virtio-scsi for an example of how to save the >> > requests using the save_request and load_request callbacks in SCSIBusInfo. > > Sigh. ? > How do you test that requests are saved/restored correctly? What does > happen to requests which were already sent to the real hardware (real block > device, etc) but have not completed at the moment of the end of migration? They aren't saved, there is a bdrv_drain_all() in the migration code. This is only used for rerror=stop or werror=stop. To test it you can use blkdebug (also a bit underdocumented) or hack block/raw-posix.c with code that makes it fail the 100th write or something like that. Start the VM and migrate it while paused to a QEMU that doesn't have the hack. Paolo