From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35037) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UgrjO-00062D-DF for qemu-devel@nongnu.org; Mon, 27 May 2013 03:20:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UgrjI-0001FC-TS for qemu-devel@nongnu.org; Mon, 27 May 2013 03:20:34 -0400 Received: from mail-ea0-x235.google.com ([2a00:1450:4013:c01::235]:37110) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UgrjI-0001F8-Mf for qemu-devel@nongnu.org; Mon, 27 May 2013 03:20:28 -0400 Received: by mail-ea0-f181.google.com with SMTP id a11so3711983eae.12 for ; Mon, 27 May 2013 00:20:28 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <51A30933.9080307@redhat.com> Date: Mon, 27 May 2013 09:20:19 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1369133851-1894-1-git-send-email-pbonzini@redhat.com> <1369133851-1894-18-git-send-email-pbonzini@redhat.com> <51A05CDF.1090106@web.de> <51A06C9B.5060302@redhat.com> <51A09018.7000901@web.de> <51A09E6F.7030109@redhat.com> <51A0A0D5.5000706@web.de> <51A1CE2F.5050508@redhat.com> <51A1CF92.7030708@web.de> In-Reply-To: <51A1CF92.7030708@web.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 17/30] memory: add address_space_translate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, David Gibson -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Il 26/05/2013 11:02, Jan Kiszka ha scritto: >>> >>> Nice patches. Only one thing, how is .impl.unaligned different >>> from the existing .valid.unaligned? > See memory.h: valid controls is an unaligned access traps or gets > processed, impl manages if it is passed as-is to the device or > broken up and aligned first. I took the following patches: exec: Allow unaligned address_space_rw exec: Resolve subpages in one step except for IOTLB fills exec: Implement subpage_read/write via address_space_rw to limit the conflicts and because I realized that TCG should never encounter an IOMMU. Thus I removed the is_write argument from address_space_translate_internal and moved the IOMMU handling to address_space_translate. I'll push to my iommu branch after some more testing. If you reorganize the old_portio handling along the lines I suggested in my previous email you should have no conflicts when rebasing. Paolo -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRowkzAAoJEBvWZb6bTYbybiQP/i4S4tUisfJVPlnKosEwxUxk LY0I6oyeXIQznv/2VC+CkKuNFRpQyPgOoD+Nc4mVdVSEgexdJdNHvT3qQeewkRBB Kk074LS/tMdtyRFyhf+ZuhYFBFgCV4LINyJ3iZV9E913LqV/cM6CXnvYcOWwNspu 2ZPGLCueG5y0iHcHHFo2ZXRf/OqUKiKIzMMKPzS57+7o7rUqav8wSnQV1Qox/L0G xeeUZ4BO9a59ULIb63bwhrjcUHS77vddvAcPDe5LifAo1OZqZWXsWvzdj/3VKY0A Deyt+q02QA9erYPR0K16nLr3j+8z44McPugHWNNmAzQzMXjFIVE1g7kBmqzBLAst tStrog73ol1xgor5xl1wIqEfGQNGOroNuPEpdlU7NQf4c6aFJ7cWFMJnaOtfZuNB 7eTtQV32lQkqns7ho3wJFsv7k2sWjpBrjrXCNnii+LH/MUUm8KsAQ+w2JVCRHEDK AEmnniEoCSLMbwZFOiKGT0J5291dZgeK6dbH2NVJ8jYhTWaDGuIldXtGyMvBkvpi +YZF4Z3vvOPFeT+zl0DPh0xHsaXcblfZbe3pe4aDDlgjmsUAbyNIsTsAIn/+eq0y WwjuEj76bR8Y+RbJgkQ1VP6mCDqQLaOAiKWniZZ1wjZMBmE3vCwsmi3CNEVMxJOD XOnhQIEOw5kautUlcnQ3 =1nFS -----END PGP SIGNATURE-----