From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UgwQu-0005K6-NE for qemu-devel@nongnu.org; Mon, 27 May 2013 08:21:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UgwQs-0002ZI-Uy for qemu-devel@nongnu.org; Mon, 27 May 2013 08:21:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35220) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UgwQs-0002Z5-Nc for qemu-devel@nongnu.org; Mon, 27 May 2013 08:21:46 -0400 Message-ID: <51A34FD0.7010902@redhat.com> Date: Mon, 27 May 2013 14:21:36 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <51A0596D.1050300@redhat.com> <20130527120951.GA2580@otherpad.lan.raisama.net> In-Reply-To: <20130527120951.GA2580@otherpad.lan.raisama.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-i386: Disable CPUID_EXT_MONITOR when KVM is enabled List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Igor Mammedov , Bandan Das , qemu-devel@nongnu.org, =?ISO-8859-1?Q?Andreas_F=E4rber?= Il 27/05/2013 14:09, Eduardo Habkost ha scritto: > On Sat, May 25, 2013 at 08:25:49AM +0200, Paolo Bonzini wrote: >> Il 25/05/2013 03:21, Bandan Das ha scritto: >>> There is one user-visible effect: "-cpu ...,enforce" will stop failing >>> because of missing KVM support for CPUID_EXT_MONITOR. But that's exactly >>> the point: there's no point in having CPU model definitions that would >>> never work as-is with neither TCG or KVM. This patch is changing the >>> meaning of (e.g.) "-machine ...,accel=kvm -cpu Opteron_G3" to match what >>> was already happening in practice. >> >> But then -cpu Opteron_G3 does not match a "real" Opteron G3. Is it >> worth it? > > No models match a "real" CPU this way, because neither TCG or KVM > support all features supported by a real CPU. I ask the opposite > question: is it worth maintaining an "accurate" CPU model definition > that would never work without feature-bit tweaking in the command-line? It would work with TCG. Changing TCG to KVM should not change hardware if you use "-cpu ...,enforce", so it is right that it fails when starting with KVM. Paolo