From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42503)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Uh0yh-0005DI-4L
	for qemu-devel@nongnu.org; Mon, 27 May 2013 13:13:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Uh0yZ-0005tR-IJ
	for qemu-devel@nongnu.org; Mon, 27 May 2013 13:12:59 -0400
Received: from mail-qc0-x22a.google.com ([2607:f8b0:400d:c01::22a]:59352)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Uh0yZ-0005rO-DQ
	for qemu-devel@nongnu.org; Mon, 27 May 2013 13:12:51 -0400
Received: by mail-qc0-f170.google.com with SMTP id s11so3665574qcw.1
	for <qemu-devel@nongnu.org>; Mon, 27 May 2013 10:12:50 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <51A3923C.7090705@twiddle.net>
Date: Mon, 27 May 2013 10:05:00 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <5141F36E.10004@huawei.com> <519DCEC8.8060000@huawei.com>
	<519DD0BF.4090702@huawei.com>
	<CAFEAcA-8DSFA1XPaqFhhyGa0MCHNNUtsxL+zOBsNJ6ZbTdTKjw@mail.gmail.com>
	<519F2A06.8090200@huawei.com> <51A32301.8030304@huawei.com>
In-Reply-To: <51A32301.8030304@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/4] tcg/aarch64: implement new TCG target
	for aarch64
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Claudio Fontana <claudio.fontana@huawei.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Jani Kokkonen <Jani.Kokkonen@huawei.com>, qemu-devel@nongnu.org

On 2013-05-27 02:10, Claudio Fontana wrote:
>>>> +    case INDEX_op_mov_i64: ext = 1;
>>>
>>> Please don't put code on the same line as a case statement.
>>> Also fall-through cases should have an explicit /* fall through */
>>> comment (except in the case where there is no code at all
>>> between one case statement and the next).
>
> Would it be acceptable to put a comment at the beginning of the function
> describing ext use, to avoiding a series of /* fall through */ comments?
>
> Like this:
>
> /* ext will be set in the switch below, which will fall through
>     to the common code. It triggers the use of extended registers
>     where appropriate. */
>
> and then going:
>
> case INDEX_op_something_64:
>      ext = 1;
> case INDEX_op_something_32:
>      the_actual_meat(s, ext, ...);
>      break;

I'll again suggest using the macro expansion that the i386 port uses.


r~