From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44461) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uh9io-0000Y5-Qu for qemu-devel@nongnu.org; Mon, 27 May 2013 22:33:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uh9im-0004AM-4i for qemu-devel@nongnu.org; Mon, 27 May 2013 22:33:10 -0400 Received: from [222.73.24.84] (port=28644 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uh9cL-0002Zm-Of for qemu-devel@nongnu.org; Mon, 27 May 2013 22:26:30 -0400 Message-ID: <51A41590.1030309@cn.fujitsu.com> Date: Tue, 28 May 2013 10:25:20 +0800 From: Wanlong Gao MIME-Version: 1.0 References: <1365749179-6069-1-git-send-email-gaowanlong@cn.fujitsu.com> <1366051167.2918.166.camel@bling.home> In-Reply-To: <1366051167.2918.166.camel@bling.home> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] pci-assign: remove the duplicate function name in debug message Reply-To: gaowanlong@cn.fujitsu.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, Alex Williamson Ping... > On Fri, 2013-04-12 at 14:46 +0800, Wanlong Gao wrote: >> While DEBUG() already includes the function name. >> >> Signed-off-by: Wanlong Gao >> --- >> hw/i386/kvm/pci-assign.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) > > Acked-by: Alex Williamson > >> >> diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c >> index c1e08ec..6afb82e 100644 >> --- a/hw/i386/kvm/pci-assign.c >> +++ b/hw/i386/kvm/pci-assign.c >> @@ -226,7 +226,7 @@ static uint32_t slow_bar_readb(void *opaque, hwaddr addr) >> uint32_t r; >> >> r = *in; >> - DEBUG("slow_bar_readl addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r); >> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r); >> >> return r; >> } >> @@ -238,7 +238,7 @@ static uint32_t slow_bar_readw(void *opaque, hwaddr addr) >> uint32_t r; >> >> r = *in; >> - DEBUG("slow_bar_readl addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r); >> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r); >> >> return r; >> } >> @@ -250,7 +250,7 @@ static uint32_t slow_bar_readl(void *opaque, hwaddr addr) >> uint32_t r; >> >> r = *in; >> - DEBUG("slow_bar_readl addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r); >> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r); >> >> return r; >> } >> @@ -260,7 +260,7 @@ static void slow_bar_writeb(void *opaque, hwaddr addr, uint32_t val) >> AssignedDevRegion *d = opaque; >> uint8_t *out = d->u.r_virtbase + addr; >> >> - DEBUG("slow_bar_writeb addr=0x" TARGET_FMT_plx " val=0x%02x\n", addr, val); >> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%02x\n", addr, val); >> *out = val; >> } >> >> @@ -269,7 +269,7 @@ static void slow_bar_writew(void *opaque, hwaddr addr, uint32_t val) >> AssignedDevRegion *d = opaque; >> uint16_t *out = (uint16_t *)(d->u.r_virtbase + addr); >> >> - DEBUG("slow_bar_writew addr=0x" TARGET_FMT_plx " val=0x%04x\n", addr, val); >> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%04x\n", addr, val); >> *out = val; >> } >> >> @@ -278,7 +278,7 @@ static void slow_bar_writel(void *opaque, hwaddr addr, uint32_t val) >> AssignedDevRegion *d = opaque; >> uint32_t *out = (uint32_t *)(d->u.r_virtbase + addr); >> >> - DEBUG("slow_bar_writel addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, val); >> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, val); >> *out = val; >> } >> > > > > >