From: Gerd Hoffmann <kraxel@redhat.com>
To: li guang <lig.fnst@cn.fujitsu.com>
Cc: qemu-trivial@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Anthony Liguori" <aliguori@us.ibm.com>,
qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON
Date: Tue, 28 May 2013 07:46:28 +0200 [thread overview]
Message-ID: <51A444B4.3020006@redhat.com> (raw)
In-Reply-To: <1369701066.19028.53.camel@liguang.fnst.cn.fujitsu.com>
On 05/28/13 02:31, li guang wrote:
> 在 2013-05-27一的 11:13 +0200，Gerd Hoffmann写道：
>> On 05/24/13 04:47, liguang wrote:
>>> when enable DEBUG_DEBUGCON, there are some message
>>> printing bugs, so fix them.
>>
>> I'd suggest to either simply remove the debug printfs or turn them into
>> tracepoints.
>>
>
> sorry, why we simply remove debug message printing?
> it's un-useful at all?
It's a case-by-case thing.
Debug messages logging guest activity like port access tend to be useful
for trouble-shooting. They should be turned into tracepoints, so they
can be toggled at runtime and integrate nicely with tracing tools.
Sometimes debug messages are just leftovers and don't serve a real
purpose (any more). Then it is best to simply remove them.
In the debugcon case I'd tend to simply remove them given how trivial
the device is. But if you prefer making them tracepoints I'm ok with that.
cheers,
Gerd
prev parent reply other threads:[~2013-05-28 5:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 2:47 [Qemu-devel] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON liguang
2013-05-24 2:47 ` [Qemu-devel] [PATCH 1/4] debugcon: fix always print "addr=0x0, val=0x0" bug when use DEBUG_DEBUGCON liguang
2013-05-24 2:47 ` [Qemu-devel] [PATCH 2/4] debugcon: make debug message more readable liguang
2013-05-24 2:47 ` [Qemu-devel] [PATCH 3/4] debugcon: fix compiler warning when open DEBUG_DEBUGCON liguang
2013-05-24 2:47 ` [Qemu-devel] [PATCH 4/4] debugcon: use fprintf(stderr...) instead of printf liguang
2013-05-24 11:55 ` Andreas Färber
2013-05-25 9:28 ` [Qemu-devel] [Qemu-trivial] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON Michael Tokarev
2013-05-25 10:35 ` Andreas Färber
2013-05-25 10:42 ` Michael Tokarev
2013-05-27 1:40 ` li guang
2013-05-27 20:42 ` Michael Tokarev
2013-05-28 0:14 ` li guang
2013-05-27 9:13 ` [Qemu-devel] " Gerd Hoffmann
2013-05-28 0:31 ` li guang
2013-05-28 5:46 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A444B4.3020006@redhat.com \
--to=kraxel@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=lig.fnst@cn.fujitsu.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).