qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: aliguori@us.ibm.com, xen-devel@lists.xensource.com,
	qemu-devel@nongnu.org, anthony.perard@citrix.com,
	pbonzini@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH 1/3] qemu_chr_new_from_opts: do not overwrite existing chr->filename
Date: Tue, 28 May 2013 08:37:15 +0200	[thread overview]
Message-ID: <51A4509B.8080109@redhat.com> (raw)
In-Reply-To: <1369678422-658-1-git-send-email-stefano.stabellini@eu.citrix.com>

On 05/27/13 20:13, Stefano Stabellini wrote:
> Set the new filename only if it hasn't been already set (for example by
> qemu_chr_open_pty).
> 
> This fixes a regression that prevents Xen HVM domains from booting.
> It was introduced by:
> 
> commit 2b220025993e76d4116781ca91a4fabc5ad9c722
> Author: Lei Li <lilei@linux.vnet.ibm.com>
> Date:   Tue May 21 18:27:59 2013 +0800

FYI: just posted a pull req which reverts this one (you are cc'ed).

cheers,
  Gerd

  reply	other threads:[~2013-05-28  6:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-27 18:13 [Qemu-devel] [PATCH 0/3] Xen related fixes Stefano Stabellini
2013-05-27 18:13 ` [Qemu-devel] [PATCH 1/3] qemu_chr_new_from_opts: do not overwrite existing chr->filename Stefano Stabellini
2013-05-28  6:37   ` Gerd Hoffmann [this message]
2013-05-28 10:43     ` Stefano Stabellini
2013-05-28 10:44   ` Stefano Stabellini
2013-05-27 18:13 ` [Qemu-devel] [PATCH 2/3] xen: simplify xen_enabled Stefano Stabellini
2013-05-27 18:13 ` [Qemu-devel] [PATCH 3/3] main_loop: do not set nonblocking if xen_enabled() Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51A4509B.8080109@redhat.com \
    --to=kraxel@redhat.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=anthony.perard@citrix.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).