From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhDXM-0002F7-B6 for qemu-devel@nongnu.org; Tue, 28 May 2013 02:37:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhDXA-0007eR-Lf for qemu-devel@nongnu.org; Tue, 28 May 2013 02:37:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52478) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhDXA-0007eI-D6 for qemu-devel@nongnu.org; Tue, 28 May 2013 02:37:24 -0400 Message-ID: <51A4509B.8080109@redhat.com> Date: Tue, 28 May 2013 08:37:15 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1369678422-658-1-git-send-email-stefano.stabellini@eu.citrix.com> In-Reply-To: <1369678422-658-1-git-send-email-stefano.stabellini@eu.citrix.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] qemu_chr_new_from_opts: do not overwrite existing chr->filename List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: aliguori@us.ibm.com, xen-devel@lists.xensource.com, qemu-devel@nongnu.org, anthony.perard@citrix.com, pbonzini@redhat.com, afaerber@suse.de On 05/27/13 20:13, Stefano Stabellini wrote: > Set the new filename only if it hasn't been already set (for example by > qemu_chr_open_pty). > > This fixes a regression that prevents Xen HVM domains from booting. > It was introduced by: > > commit 2b220025993e76d4116781ca91a4fabc5ad9c722 > Author: Lei Li > Date: Tue May 21 18:27:59 2013 +0800 FYI: just posted a pull req which reverts this one (you are cc'ed). cheers, Gerd