From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhEXR-00030w-I6 for qemu-devel@nongnu.org; Tue, 28 May 2013 03:41:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhEXM-0004ag-5b for qemu-devel@nongnu.org; Tue, 28 May 2013 03:41:45 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55999 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhEXL-0004aO-TF for qemu-devel@nongnu.org; Tue, 28 May 2013 03:41:40 -0400 Message-ID: <51A45FAF.1030101@suse.de> Date: Tue, 28 May 2013 09:41:35 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1366705016-30471-1-git-send-email-lig.fnst@cn.fujitsu.com> <519F5107.1060200@suse.de> <51A23075.1060309@suse.de> <1369707067.19028.58.camel@liguang.fnst.cn.fujitsu.com> In-Reply-To: <1369707067.19028.58.camel@liguang.fnst.cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [update][PATCH 00/12] target-i386: remove some macros List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: li guang Cc: peter.maydell@linaro.org, ehabkost@redhat.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, pbonzini@redhat.com, imammedo@redhat.com, rth@twiddle.net Am 28.05.2013 04:11, schrieb li guang: > =E5=9C=A8 2013-05-26=E6=97=A5=E7=9A=84 17:55 +0200=EF=BC=8CAndreas F=C3= =A4rber=E5=86=99=E9=81=93=EF=BC=9A >> Am 24.05.2013 13:37, schrieb Andreas F=C3=A4rber: >>> Am 23.04.2013 10:16, schrieb liguang: >>>> remove macros EAX, EBX, ECX, EDX, EBP, ESP, ESI, EDI, EIP, DF >>>> as suggested by Richard Henderson >>>> >>>> Li Guang (12) >>>> target-i386/helper: remove EAX macro >>>> target-i386/helper: remove EBX macro >>>> target-i386/helper: remove ECX macro >>>> target-i386/helper: remove EDX macro >>>> target-i386/helper: remove EBP macro >>>> target-i386/helper: remove ESP macro >>>> target-i386/helper: remove ESI macro >>>> target-i386/helper: remove EDI macro >>>> target-i386/helper: remove EIP macro >>>> target-i386/helper: remove DF macro >>>> target-i386/helper: remove redundant env->eip assignment >>>> target-i386: fix over 80 chars warnings >>> >>> Hard Freeze is over, so more time to look into refactorings: >>> >>> There's one thing to be aware of here, macros would make it easier to >>> transition from CPUX86State to X86CPU fields. However I am guessing t= hat >>> all these registers are accessed by TCG code via offsets from cpu_env= - >>> please verify that. >> >> Confirmed, I just stumbled over it myself in translate.c: >> * all but EIP and DF are assigned to cpu_regs[] >> * EIP is manually stored with offsetof() twice >> * DF is manually loaded/stored with offsetof() thrice >> >=20 > Hi, Andreas >=20 > do you mean I should not remove macros EIP and DF ? I'm OK with all 12 patches as stated before. However as pointed out below ... >=20 > or can you pick these patches or cherry-pick some of them. >=20 > Thanks! >=20 >> >>> If so, >>> >>> Reviewed-by: Andreas F=C3=A4rber >>> >>> However, it would be nice if you could fix the \ alignment in patch >>> 06/12 or in the cleanup patch 12/12. ... patch 06/12 breaks the alignment of the '\' characters through your search-and-replace, so please fix that up in patch 06/12 or in 12/12 or append a 13th patch. I'm not the maintainer of target-i386 TCG code, so this is not for me to pick up, therefore my Reviewed-by. I'm expecting rth or Blue to pick them up once you've sent a v4. Thanks, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg