qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: li guang <lig.fnst@cn.fujitsu.com>
Cc: peter.maydell@linaro.org, ehabkost@redhat.com,
	qemu-devel@nongnu.org, blauwirbel@gmail.com, pbonzini@redhat.com,
	imammedo@redhat.com, rth <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v4 00/12] target-i386: remove some macros
Date: Tue, 28 May 2013 10:30:26 +0200	[thread overview]
Message-ID: <51A46B22.2010607@suse.de> (raw)
In-Reply-To: <1369729154.19028.78.camel@liguang.fnst.cn.fujitsu.com>

Am 28.05.2013 10:19, schrieb li guang:
> remove macros EAX, EBX, ECX, EDX, EBP, ESP, ESI, EDI, EIP, DF
> as suggested by Richard Henderson <rth@twiddle.net>
> 
> v4: fix alignment issue in patch 6.

Thanks, I reviewed patch 6, the rest was already Reviewed-by, so

> 
> Li Guang (12)
>          target-i386/helper: remove EAX macro
>          target-i386/helper: remove EBX macro
>          target-i386/helper: remove ECX macro
>          target-i386/helper: remove EDX macro
>          target-i386/helper: remove EBP macro
>          target-i386/helper: remove ESP macro
>          target-i386/helper: remove ESI macro
>          target-i386/helper: remove EDI macro
>          target-i386/helper: remove EIP macro
>          target-i386/helper: remove DF macro
>          target-i386/helper: remove redundant env->eip assignment
>          target-i386: fix over 80 chars warnings

Reviewed-by: Andreas Färber <afaerber@suse.de>

Thanks,
Andreas

> cpu-exec.c                |   4 ++--
> target-i386/cc_helper.c   |   2 +-
> target-i386/cpu.h         |  24 -
> target-i386/excp_helper.c |   2 +-
> target-i386/int_helper.c  |  86
> ++++++++++++++++++++++----------------------
> target-i386/mem_helper.c  |  24 +++---
> target-i386/misc_helper.c | 107 +++---
> target-i386/seg_helper.c  | 182 +++---
> target-i386/smm_helper.c  |  64 +++---
> target-i386/svm_helper.c  |  66 ++++++++--------
> 10 files changed, 280 insertions(+), 281 deletions(-)

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  reply	other threads:[~2013-05-28  8:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-28  8:19 [Qemu-devel] [PATCH v4 00/12] target-i386: remove some macros li guang
2013-05-28  8:30 ` Andreas Färber [this message]
2013-05-28 14:55 ` Richard Henderson
2013-06-11  0:02 ` li guang
2013-06-15 17:56 ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51A46B22.2010607@suse.de \
    --to=afaerber@suse.de \
    --cc=blauwirbel@gmail.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=lig.fnst@cn.fujitsu.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).