From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33347)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UhFIe-0007RJ-UT
	for qemu-devel@nongnu.org; Tue, 28 May 2013 04:30:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UhFIb-0003m7-5V
	for qemu-devel@nongnu.org; Tue, 28 May 2013 04:30:32 -0400
Received: from cantor2.suse.de ([195.135.220.15]:57743 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UhFIa-0003lr-S1
	for qemu-devel@nongnu.org; Tue, 28 May 2013 04:30:28 -0400
Message-ID: <51A46B22.2010607@suse.de>
Date: Tue, 28 May 2013 10:30:26 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1369729154.19028.78.camel@liguang.fnst.cn.fujitsu.com>
In-Reply-To: <1369729154.19028.78.camel@liguang.fnst.cn.fujitsu.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4 00/12] target-i386: remove some macros
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: li guang <lig.fnst@cn.fujitsu.com>
Cc: peter.maydell@linaro.org, ehabkost@redhat.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, pbonzini@redhat.com, imammedo@redhat.com, rth <rth@twiddle.net>

Am 28.05.2013 10:19, schrieb li guang:
> remove macros EAX, EBX, ECX, EDX, EBP, ESP, ESI, EDI, EIP, DF
> as suggested by Richard Henderson <rth@twiddle.net>
>=20
> v4: fix alignment issue in patch 6.

Thanks, I reviewed patch 6, the rest was already Reviewed-by, so

>=20
> Li Guang (12)
>          target-i386/helper: remove EAX macro
>          target-i386/helper: remove EBX macro
>          target-i386/helper: remove ECX macro
>          target-i386/helper: remove EDX macro
>          target-i386/helper: remove EBP macro
>          target-i386/helper: remove ESP macro
>          target-i386/helper: remove ESI macro
>          target-i386/helper: remove EDI macro
>          target-i386/helper: remove EIP macro
>          target-i386/helper: remove DF macro
>          target-i386/helper: remove redundant env->eip assignment
>          target-i386: fix over 80 chars warnings

Reviewed-by: Andreas F=C3=A4rber <afaerber@suse.de>

Thanks,
Andreas

> cpu-exec.c                |   4 ++--
> target-i386/cc_helper.c   |   2 +-
> target-i386/cpu.h         |  24 -
> target-i386/excp_helper.c |   2 +-
> target-i386/int_helper.c  |  86
> ++++++++++++++++++++++----------------------
> target-i386/mem_helper.c  |  24 +++---
> target-i386/misc_helper.c | 107 +++---
> target-i386/seg_helper.c  | 182 +++---
> target-i386/smm_helper.c  |  64 +++---
> target-i386/svm_helper.c  |  66 ++++++++--------
> 10 files changed, 280 insertions(+), 281 deletions(-)

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg