From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39660)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UhFpA-0000f5-Hm
	for qemu-devel@nongnu.org; Tue, 28 May 2013 05:04:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UhFp0-0006Dd-K4
	for qemu-devel@nongnu.org; Tue, 28 May 2013 05:04:08 -0400
Message-ID: <51A472FB.8020400@suse.de>
Date: Tue, 28 May 2013 11:03:55 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1369409217-7553-1-git-send-email-peter.maydell@linaro.org>
	<1369409217-7553-2-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1369409217-7553-2-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/4] configure: Require libfdt for arm, ppc,
 microblaze softmmu targets
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Anthony Liguori <aliguori@us.ibm.com>, patches@linaro.org, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org, =?ISO-8859-15?Q?Andr?= =?ISO-8859-15?Q?eas_F=E4rber?= <andreas.faerber@web.de>, qemu-ppc@nongnu.org, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>

Am 24.05.2013 17:26, schrieb Peter Maydell:
> A number of our softmmu targets (PPC, ARM, Microblaze) now more or
> less require flattened device tree support for various board models
> to work correctly.  Make libfdt mandatory if the target list includes
> these, rather than building unhelpful half-functional binaries.
>=20
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  configure |   20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>=20
> diff --git a/configure b/configure
> index 5ae7e4a..708c010 100755
> --- a/configure
> +++ b/configure
> @@ -2518,6 +2518,26 @@ fi
> =20
>  ##########################################
>  # fdt probe
> +# fdt support is mandatory for at least some target architectures,
> +# so insist on it if we're building those system emulators.
> +fdt_required=3Dno
> +for target in $target_list; do
> +  case $target in
> +    arm*softmmu|ppc*softmmu|microblaze*softmmu)

Assuming you'll apply this through your tree, it would be more
self-explanatory to use foo*-softmmu despite no practical difference.

I'm guessing arm* is in preparation for a future armeb-softmmu?

Otherwise looks good; still have testing pseries on my TODO list.

Andreas

> +      fdt_required=3Dyes
> +    ;;
> +  esac
> +done
> +
> +if test "$fdt_required" =3D "yes"; then
> +  if test "$fdt" =3D "no"; then
> +    error_exit "fdt disabled but some requested targets require it." \
> +      "You can turn off fdt only if you also disable all the system em=
ulation" \
> +      "targets which need it (by specifying a cut down --target-list).=
"
> +  fi
> +  fdt=3Dyes
> +fi
> +
>  if test "$fdt" !=3D "no" ; then
>    fdt_libs=3D"-lfdt"
>    cat > $TMPC << EOF

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg