From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhGNn-0003Dw-QZ for qemu-devel@nongnu.org; Tue, 28 May 2013 05:40:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhGNc-0001AK-Qa for qemu-devel@nongnu.org; Tue, 28 May 2013 05:39:55 -0400 Received: from cantor2.suse.de ([195.135.220.15]:60340 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhGNc-00019x-I1 for qemu-devel@nongnu.org; Tue, 28 May 2013 05:39:44 -0400 Message-ID: <51A47B5D.90702@suse.de> Date: Tue, 28 May 2013 11:39:41 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1369228150-5428-1-git-send-email-afaerber@suse.de> <1369228150-5428-5-git-send-email-afaerber@suse.de> <519DEAA4.3090209@redhat.com> In-Reply-To: <519DEAA4.3090209@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu 4/4] memory_mapping: Move stubs to libqemustub.a List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Vincent Rabin , Qiao Nuohan , qemu-devel@nongnu.org, Jens Freimann Am 23.05.2013 12:08, schrieb Paolo Bonzini: > Il 22/05/2013 15:09, Andreas F=C3=A4rber ha scritto: >> Allows us to drop CONFIG_NO_GET_MEMORY_MAPPING with its indirect >> dependency on CONFIG_HAVE_GET_MEMORY_MAPPING in Makefile.target. >> >> Signed-off-by: Andreas F=C3=A4rber >> --- >> Makefile.target | 2 -- >> stubs/Makefile.objs | 1 + >> memory_mapping-stub.c =3D> stubs/memory_mapping.c | 5 +++-- >> 3 files changed, 4 insertions(+), 4 deletions(-) >> rename memory_mapping-stub.c =3D> stubs/memory_mapping.c (85%) [...] >> diff --git a/memory_mapping-stub.c b/stubs/memory_mapping.c >> similarity index 85% >> rename from memory_mapping-stub.c >> rename to stubs/memory_mapping.c >> index c48ea44..4db2108 100644 >> --- a/memory_mapping-stub.c >> +++ b/stubs/memory_mapping.c >> @@ -11,8 +11,9 @@ >> * >> */ >> =20 >> -#include "cpu.h" >> -#include "exec/cpu-all.h" >> +#include "qemu-common.h" >> +#include "exec/cpu-common.h" >> +#include "qom/cpu.h" >> #include "sysemu/memory_mapping.h" >> =20 >> int qemu_get_guest_memory_mapping(MemoryMappingList *list) >> >=20 > Patches 1-3 are fine. Thanks. > But I wonder if a better replacement for stubs is > methods in CPU. None of the functions I have moved from *-stub.c to stubs/ operate on a single CPU, so now that the conflict with the kdump format support has been resolved I'd like to move them as a step towards dropping per-target configure changes for guest-memory-dump support. With my note in the cover letter I was rather referring to cpu_paging_enabled(), which is mandatory currently without any stub. Do you have a concrete suggestion what else to do for these stubs? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg