From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55809) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhH4v-0006kV-OE for qemu-devel@nongnu.org; Tue, 28 May 2013 06:24:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhH4k-0007FP-5V for qemu-devel@nongnu.org; Tue, 28 May 2013 06:24:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51359) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhH4j-0007FK-Th for qemu-devel@nongnu.org; Tue, 28 May 2013 06:24:18 -0400 Message-ID: <51A4865A.8080702@redhat.com> Date: Tue, 28 May 2013 12:26:34 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <1369726806-9715-1-git-send-email-akong@redhat.com> <51A4659B.8060601@redhat.com> In-Reply-To: <51A4659B.8060601@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] boot: fix path pattern of scsi device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Amos Kong Cc: kevin@koconnor.net, seabios@seabios.org, qemu-devel@nongnu.org, =?ISO-8859-1?Q?KONRAD_Fr=E9d=E9ric?= On 05/28/13 10:06, Paolo Bonzini wrote: > Il 28/05/2013 09:40, Amos Kong ha scritto: >> bootindex parameter of scsi device doesn't work, it causes >> by wrong pattern in seabios. >> >> qemu passes the following firmware dev_path to seabios: >> /pci@i0cf8/scsi@4/virtio-scsi-device/channel@0/disk@0,0 > > No, this is another unexpected change due to the virtio refactoring in > QEMU. The right fix is in QEMU, by adding a get_fw_dev_path > implementation in hw/virtio/virtio-bus.c. > > We fixed it already for migration paths, it should be easy to do the > same for this. > > Please Cc qemu-stable@nongnu.org when sending the QEMU patch. > > Thanks, > > Paolo Ahhh. I was super confused by this patch initially. Amos, when posting a patch to both lists, please add the project name to the bracketed bag-of-tags in the subject, like [SeaBIOS PATCH] boot: fix path pattern of scsi device I saw this message first on qemu-devel, and until I noticed "src/boot.c" I was kind of confused whom you want to adapt to whom, and in what direction Paolo argues against it. So, virtio refactoring in QEMU (care to name a commit or release?) changed the OpenFirmware device path exported for virtio-scsi devices under the boot order fw_cfg key. This patch intended to adapt SeaBIOS to recognize the new OFW devpath. Under this approach I would have to update QemuBootOrder.c in OVMF in parallel, so that it accepts both old and new style OFW devpaths for virtio-scsi. However Paolo says the new style OFW devpath should be fixed (eliminated) in qemu, and consumers shouldn't notice any change in the long term. And I won't have to change QemuBootOrder.c. Right? Thanks! Laszlo