From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33154)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1UhHUM-0000A2-Uy
	for qemu-devel@nongnu.org; Tue, 28 May 2013 06:50:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1UhHUH-00077v-13
	for qemu-devel@nongnu.org; Tue, 28 May 2013 06:50:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41503)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1UhHUG-00077r-Pd
	for qemu-devel@nongnu.org; Tue, 28 May 2013 06:50:40 -0400
Message-ID: <51A48BF7.4080302@redhat.com>
Date: Tue, 28 May 2013 12:50:31 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1367935572-15501-1-git-send-email-emaste@freebsd.org>
	<CAPyFy2CoaFnmrrcwxtT5ckdY=+PFSYx-UCZuoC7qge8oOXBbQA@mail.gmail.com>
In-Reply-To: <CAPyFy2CoaFnmrrcwxtT5ckdY=+PFSYx-UCZuoC7qge8oOXBbQA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] host-libusb: Correct test for USB packet
 state
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ed Maste <emaste@freebsd.org>
Cc: qemu-devel@nongnu.org

On 05/21/13 15:45, Ed Maste wrote:
> On 7 May 2013 10:06, Ed Maste <emaste@freebsd.org> wrote:
>> USB_RET_ASYNC is -6, so inflight was always false.
> 
> Ping.  I believe the "if (inflight)" block in usb_host_req_abort() can
> never be executed in the current code.

Patch added to usb patch queue.

thanks,
  Gerd