From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56732) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhJ4M-0002L2-Vr for qemu-devel@nongnu.org; Tue, 28 May 2013 08:32:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhJ4K-0007xg-1h for qemu-devel@nongnu.org; Tue, 28 May 2013 08:32:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21363) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhJ4J-0007xP-QH for qemu-devel@nongnu.org; Tue, 28 May 2013 08:31:59 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4SCVwur005216 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 28 May 2013 08:31:58 -0400 Message-ID: <51A4A3BD.3070605@redhat.com> Date: Tue, 28 May 2013 06:31:57 -0600 From: Eric Blake MIME-Version: 1.0 References: <1369661331-28041-1-git-send-email-stefanha@redhat.com> In-Reply-To: <1369661331-28041-1-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2FOIFQMEQHXDBUNWEKCKN" Subject: Re: [Qemu-devel] [PATCH v4] tests: set MALLOC_PERTURB_ to expose memory bugs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: lmr@redhat.com, qemu-devel@nongnu.org, Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2FOIFQMEQHXDBUNWEKCKN Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/27/2013 07:28 AM, Stefan Hajnoczi wrote: > glibc wipes malloc(3) memory when the MALLOC_PERTURB_ environment > variable is set. The value of the environment variable determines the > bit pattern used to wipe memory. For more information, see > http://udrepper.livejournal.com/11429.html. >=20 > Set MALLOC_PERTURB_ for gtester and qemu-iotests. Note we pick a rando= m > value from 1 to 255 to expose more bugs. If you need to reproduce a > crash use 'show environment' in gdb to extract the MALLOC_PERTURB_ > value from a core dump. >=20 > Both make check and qemu-iotests pass with MALLOC_PERTURB_ enabled. >=20 > Signed-off-by: Stefan Hajnoczi > --- > Embarassing how long it's taking to get this right :P But at least the code review process prevents your embarrassment from being codified into qemu.git across multiple commits :) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2FOIFQMEQHXDBUNWEKCKN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRpKO9AAoJEKeha0olJ0Nq4G4H/1lv8zjFar43w2XySWOupHf+ 7ziqxqTUYOkK6MplZA8/rrBNF75IkK95KXveF7abWYhrun5drCB6esjFJxNzwKrM mH9+/Qk0HzKwaXxL4cmZtW00T1LzRPPex8Dkii8Mo8MHK5zggWpuRsx6mQpS76ik TUERt8L19m2pwTjW45GCl1fkwa/iAjqXmuOCntJlA2v3KALYIACOO9KI1xsTRCoB k19qQyrpUUqmAsmmV58B+wvbbIMZEZKbsIYrkhR4LuoiHrnWxCHL1oDFH9FyTWKK tVG7Dt80morDmX833KeFGe9RPbXo6zubqfdZg3opD64xBV7baD/EzWW9NNmvPtY= =PamN -----END PGP SIGNATURE----- ------enig2FOIFQMEQHXDBUNWEKCKN--