From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58723) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhJA1-0008KU-TJ for qemu-devel@nongnu.org; Tue, 28 May 2013 08:37:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhJ9w-0001qL-L3 for qemu-devel@nongnu.org; Tue, 28 May 2013 08:37:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44834) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhJ9w-0001p4-CA for qemu-devel@nongnu.org; Tue, 28 May 2013 08:37:48 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4SCblfg031457 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 28 May 2013 08:37:47 -0400 Message-ID: <51A4A512.7050206@redhat.com> Date: Tue, 28 May 2013 14:37:38 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1369621146-17095-1-git-send-email-alevy@redhat.com> <51A2FE14.2050501@redhat.com> <1369742995.31959.1.camel@localhost> <51A4A079.4020603@redhat.com> <1369744385.31959.7.camel@localhost> In-Reply-To: <1369744385.31959.7.camel@localhost> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC] Add a stp file for usage from build directory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: qemu-devel@nongnu.org Il 28/05/2013 14:33, Alon Levy ha scritto: > On Tue, 2013-05-28 at 14:18 +0200, Paolo Bonzini wrote: >> Il 28/05/2013 14:09, Alon Levy ha scritto: >>>>> + --probe-prefix=qemu.local \ >>>> >>>> Why change the prefix? >>> >>> It was one way to verify I was using the correct file. I'll change it >>> back. >>> >>> But in general does it make sense for you to have this in addition to >>> the existing stp file? >> >> I think it does (with the same prefix so that you can share the >> scripts). But I'm not sure how you'd use it. :) Can you show an >> example and also put it in the commit message? > > I though it would be useful to have a bunch of scripts for developers. I > have the following (didn't fix yet to use the same prefix): Ok, so it's just a matter of using the -I option to stap. That's the bit that has to be in the commit message. Thanks! Paolo > diff --git a/scripts/stap-qxl-generic b/scripts/stap-qxl-generic > new file mode 100755 > index 0000000..1c21911 > --- /dev/null > +++ b/scripts/stap-qxl-generic > @@ -0,0 +1,4 @@ > +#!/bin/bash -x > +STP=$0.stp > +ROOT=`dirname $0`/../ > +sudo stap -v -I $ROOT/x86_64-softmmu $STP > diff --git a/scripts/stap-qxl-generic.stp b/scripts/stap-qxl-generic.stp > new file mode 100644 > index 0000000..e201e69 > --- /dev/null > +++ b/scripts/stap-qxl-generic.stp > @@ -0,0 +1,24 @@ > +probe begin { printf("starting qxl generic probe\n") } > + > +global call, threads > + > +probe qemu.local.qxl* { > + //printf("%d: %s: %s\n", tid(), pp(), $$vars) > + //print_ubacktrace() > + call[tid(), probefunc()] <<< 1 > + threads[tid()] <<< 1 > +} > + > +probe timer.s(%( $# > 0 %? $1 %: 5 %)) { > + ansi_clear_screen() > + printf("%10s %45s %s\n", "TID", "", "HITS"); > + foreach([t] in threads-) { > + printf("%10d %45s %d\n", t, "", @count(threads[t])); > + } > + printf("%10s %45s %s\n", > + "TID", "CALL", "HITS") > + foreach([tid, name] in call-) { > + printf("%10d %45s %d\n", tid, name, > + @count(call[tid, name])) > + } > +} > > >> >> Paolo >> >> > >