From: Jan Kiszka <jan.kiszka@siemens.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH trivial] slirp: cleanup leftovers from misc.h
Date: Wed, 29 May 2013 15:59:58 +0900 [thread overview]
Message-ID: <51A5A76E.6010205@siemens.com> (raw)
In-Reply-To: <1369687911-9731-1-git-send-email-mjt@msgid.tls.msk.ru>
On 2013-05-28 05:51, Michael Tokarev wrote:
> There are quite a few leftover declarations in slirp/misc.h.
> Remove them.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> slirp/misc.h | 14 --------------
> 1 file changed, 14 deletions(-)
>
> I'm not entirely sure we should do this, since this kind of
> changes just moves us more and more away from the upstream, but...
AFAIK, there is no upstream worth tracking, so this is fine.
Jan
>
> diff --git a/slirp/misc.h b/slirp/misc.h
> index cc36aeb..ba8beb1 100644
> --- a/slirp/misc.h
> +++ b/slirp/misc.h
> @@ -20,8 +20,6 @@ struct ex_list {
> char *strdup(const char *);
> #endif
>
> -void do_wait(int);
> -
> #define EMU_NONE 0x0
>
> /* TCP emulations */
> @@ -51,21 +49,9 @@ struct emu_t {
> struct emu_t *next;
> };
>
> -extern int x_port, x_server, x_display;
> -
> -int show_x(char *, struct socket *);
> -void redir_x(uint32_t, int, int, int);
> void slirp_insque(void *, void *);
> void slirp_remque(void *);
> int add_exec(struct ex_list **, int, char *, struct in_addr, int);
> -int slirp_openpty(int *, int *);
> int fork_exec(struct socket *so, const char *ex, int do_pty);
> -void snooze_hup(int);
> -void snooze(void);
> -void relay(int);
> -void add_emu(char *);
> -void fd_nonblock(int);
> -void fd_block(int);
> -int rsh_exec(struct socket *, struct socket *, char *, char *, char *);
>
> #endif
>
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
prev parent reply other threads:[~2013-05-29 7:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-27 20:51 [Qemu-devel] [PATCH trivial] slirp: cleanup leftovers from misc.h Michael Tokarev
2013-05-29 6:59 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A5A76E.6010205@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).