From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57146) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UheuB-0000ge-AO for qemu-devel@nongnu.org; Wed, 29 May 2013 07:51:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uheu8-0007DF-8t for qemu-devel@nongnu.org; Wed, 29 May 2013 07:50:59 -0400 Received: from cantor2.suse.de ([195.135.220.15]:51585 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uheu7-0007D9-Rv for qemu-devel@nongnu.org; Wed, 29 May 2013 07:50:56 -0400 Message-ID: <51A5EB9E.7000607@suse.de> Date: Wed, 29 May 2013 13:50:54 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1369827246-2802-1-git-send-email-kwolf@redhat.com> <1369827246-2802-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1369827246-2802-3-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/3] ide: Set BSY bit during FLUSH List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com Am 29.05.2013 13:34, schrieb Kevin Wolf: > From: Andreas F=C3=A4rber >=20 > The implementation of the ATA FLUSH command invokes a flush at the bloc= k > layer, which may on raw files on POSIX entail a synchronous fdatasync()= . > This may in some cases take so long that the SLES 11 SP1 guest driver > reports I/O errors and filesystems get corrupted or remounted read-only= . >=20 > Avoid this by setting BUSY_STAT, so that the guest is made aware we are > in the middle of an operation and no ATA commands are attempted to be > processed concurrently. >=20 > Addresses BNC#637297. >=20 > Suggested-by: Gonglei (Arei) > Signed-off-by: Andreas F=C3=A4rber > Signed-off-by: Kevin Wolf > --- > hw/ide/core.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/hw/ide/core.c b/hw/ide/core.c > index c7a8041..bf1ff18 100644 > --- a/hw/ide/core.c > +++ b/hw/ide/core.c > @@ -795,6 +795,8 @@ static void ide_flush_cb(void *opaque, int ret) > { > IDEState *s =3D opaque; > =20 > + s->status &=3D ~BUSY_STAT; > + > if (ret < 0) { > /* XXX: What sector number to set here? */ > if (ide_handle_rw_error(s, -ret, BM_STATUS_RETRY_FLUSH)) { Didn't you want this hunk to be dropped? But thanks for picking the patch up already. Andreas > @@ -814,6 +816,7 @@ void ide_flush_cache(IDEState *s) > return; > } > =20 > + s->status |=3D BUSY_STAT; > bdrv_acct_start(s->bs, &s->acct, 0, BDRV_ACCT_FLUSH); > bdrv_aio_flush(s->bs, ide_flush_cb, s); > } >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg