qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: aliguori@us.ibm.com, xen-devel@lists.xensource.com,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	qemu-devel@nongnu.org, qemu-stable@nongnu.org,
	anthony.perard@citrix.com, imammedo@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 3/3] xen_machine_pv: do not create a dummy CPU in machine->init
Date: Wed, 29 May 2013 14:29:51 +0200	[thread overview]
Message-ID: <51A5F4BF.90504@redhat.com> (raw)
In-Reply-To: <51A5F06A.4040109@suse.de>

Il 29/05/2013 14:11, Andreas Färber ha scritto:
>> xen_machine_pv uses cpu_x86_init, therefore it has been broken.
>>
>> This patch fixes the problem by removing the dummy CPU creation
>> altogether from xen_init_pv, relying on the fact that QEMU can now cope
>> with a machine without an emulated CPU.
>>
>> This fix should be backported to QEMU 1.5.
>>
>> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>> CC: imammedo@redhat.com
>> CC: qemu-stable@nongnu.org
> 
> Change looks okay,
> 
> Reviewed-by: Andreas Färber <afaerber@suse.de>
> 
> But for the future please avoid "this patch" in the commit message
> (because later on it's a "commit", not a patch) and also please put
> additional notices such as for backporting below the --- line.

I read it as a warning to backporters that the patch, even though it may
apply, was not tested and may even be wrong in 1.4.

Paolo

  reply	other threads:[~2013-05-29 12:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-29 11:18 [Qemu-devel] [PATCH v2 0/3] Xen related fixes Stefano Stabellini
2013-05-29 11:34 ` [Qemu-devel] [PATCH v2 1/3] xen: simplify xen_enabled Stefano Stabellini
2013-05-29 11:34 ` [Qemu-devel] [PATCH v2 2/3] main_loop: do not set nonblocking if xen_enabled() Stefano Stabellini
2013-05-29 11:34 ` [Qemu-devel] [PATCH v2 3/3] xen_machine_pv: do not create a dummy CPU in machine->init Stefano Stabellini
2013-05-29 12:11   ` Andreas Färber
2013-05-29 12:29     ` Paolo Bonzini [this message]
2013-05-29 13:09       ` Stefano Stabellini
2013-05-29 14:35       ` Igor Mammedov
2013-05-31 10:57 ` [Qemu-devel] [PATCH v2 0/3] Xen related fixes Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51A5F4BF.90504@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=anthony.perard@citrix.com \
    --cc=imammedo@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).