From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uhn0P-00028Q-9D for qemu-devel@nongnu.org; Wed, 29 May 2013 16:30:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uhn0K-0006wn-Fe for qemu-devel@nongnu.org; Wed, 29 May 2013 16:29:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uhn0K-0006wf-6I for qemu-devel@nongnu.org; Wed, 29 May 2013 16:29:52 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4TKTp2F016115 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 May 2013 16:29:51 -0400 Message-ID: <51A6653E.80803@redhat.com> Date: Wed, 29 May 2013 14:29:50 -0600 From: Eric Blake MIME-Version: 1.0 References: <1369754856-30036-1-git-send-email-kwolf@redhat.com> <1369754856-30036-7-git-send-email-kwolf@redhat.com> In-Reply-To: <1369754856-30036-7-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2NBRNRSADCOJNGPXMXDJJ" Subject: Re: [Qemu-devel] [PATCH 06/16] qemu-io: Split off commands to qemu-io-cmds.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2NBRNRSADCOJNGPXMXDJJ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/28/2013 09:27 AM, Kevin Wolf wrote: > This is the implementation of all qemu-io commands that make sense to b= e > called from the qemu monitor, i.e. everything except open, close and > quit. >=20 > Signed-off-by: Kevin Wolf > --- > Makefile | 2 +- > qemu-io-cmds.c | 1835 ++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > qemu-io.c | 1817 +-----------------------------------------------= ------- > 3 files changed, 1838 insertions(+), 1816 deletions(-) > create mode 100644 qemu-io-cmds.c I checked the bulk of this patch via: $ diff -u <(sed -n '/^-/ s///p' file) <(sed -n '/^\+/ s///p' file) The bulk of the patch is blind code motion plus a bit of touchup; I did however spot one case where you were too eager in your search-and-replace= : * Memory allocation helpers. * - * Make sure memory is aligned by default, or purposefully misaligned if= + * Make sure memory is aligned by default, or purposefully qemuio_misaligned if * that is specified on the command line. > + > +int qemuio_misalign; Should this variable be typed 'bool'? Other than that, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2NBRNRSADCOJNGPXMXDJJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRpmU+AAoJEKeha0olJ0NqlkcH/3s4s4FQlBGMNfLWLqegDGQH JjIxUjYj1mQNFXJ1QoQ5pplSJxDDjSmWb26+sUoRw0VaS9+0BCV00IwNZWIV7SaZ oWbiGdmRC6grCB9KMFJ/QfLtiXiWHgwBn7cdDcc272PrOfXkgqtqwfGikNR2hULW la0aU5bFYBLmNKuxpyO/mh+/GNIZS/pgPjUtJGOyPYWIvy1s9c0xBAg50sHWB6Og iPv4rPQGq6jLmMtEKTbTaTmjEi9Dg7eWYe9SBZ0KIWwOwJgvZNa1SeglSN1cV2N0 yvJfuoDFMqzfjEbA9MOvhU/PKsKBscy90gjEMEVtSL5mGMbgoifxwG4Ko0+0UaQ= =SPUg -----END PGP SIGNATURE----- ------enig2NBRNRSADCOJNGPXMXDJJ--