From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uhnex-0005y5-7v for qemu-devel@nongnu.org; Wed, 29 May 2013 17:11:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uhnes-0003M8-Du for qemu-devel@nongnu.org; Wed, 29 May 2013 17:11:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63473) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uhnes-0003M1-5C for qemu-devel@nongnu.org; Wed, 29 May 2013 17:11:46 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4TLBjgx031618 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 May 2013 17:11:45 -0400 Message-ID: <51A66F10.8040101@redhat.com> Date: Wed, 29 May 2013 15:11:44 -0600 From: Eric Blake MIME-Version: 1.0 References: <1369754856-30036-1-git-send-email-kwolf@redhat.com> <1369754856-30036-8-git-send-email-kwolf@redhat.com> In-Reply-To: <1369754856-30036-8-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2JGKACROQOQXCOKVWRGKW" Subject: Re: [Qemu-devel] [PATCH 07/16] qemu-io: Factor out qemuio_command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2JGKACROQOQXCOKVWRGKW Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/28/2013 09:27 AM, Kevin Wolf wrote: > It's duplicated code. Move it to qemu-io-cmds.c because it's not > dependent on any static data of the qemu-io tool. >=20 > Signed-off-by: Kevin Wolf > --- > cmd.c | 43 +++++-------------------------------------- > cmd.h | 3 ++- > qemu-io-cmds.c | 24 ++++++++++++++++++++++++ > 3 files changed, 31 insertions(+), 39 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2JGKACROQOQXCOKVWRGKW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRpm8QAAoJEKeha0olJ0NqU6gH/1WET8wUIPlygumoOxQg1spN VKsMNXayvBnPijKX5fTa0Q7lNfHE2hbeq001nz2kSaQlJAMKY+tAt/kqI80tKyT7 9BWJDLUXxJFuoB0VVMs2eZj+nPyP9xboh0gYlyxfKR1gxhTqTPFHnchPyOtJYvoy LCZ6Os9dsqKfSEAp8Pacjl9Cf9voV5aPRftrR3jiktOTFUCvoozWSTaPxzi9mzRh jeDoHy5zgY4017MEm8BUeCCV42P+Et85XpKrMxx3IVJPEVdwvkx4n5vttwak36CW VmePYuS0XQLNz93ViP8GqfjgEyoU+Nt2oHsJVNyyKj5oIaqu+gBiTfa7lkMQ1Ao= =ZyxI -----END PGP SIGNATURE----- ------enig2JGKACROQOQXCOKVWRGKW--