From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33196) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhspO-0001hE-Er for qemu-devel@nongnu.org; Wed, 29 May 2013 22:43:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhspJ-0008FO-V1 for qemu-devel@nongnu.org; Wed, 29 May 2013 22:42:58 -0400 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:48833) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhspF-00083n-G7 for qemu-devel@nongnu.org; Wed, 29 May 2013 22:42:53 -0400 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 30 May 2013 12:40:06 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 6D13F2BB0055 for ; Thu, 30 May 2013 12:42:36 +1000 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r4U2SIv323920640 for ; Thu, 30 May 2013 12:28:18 +1000 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r4U2gZoT014606 for ; Thu, 30 May 2013 12:42:35 +1000 Message-ID: <51A6BC41.7090803@linux.vnet.ibm.com> Date: Thu, 30 May 2013 10:41:05 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1369451385-23452-1-git-send-email-xiawenc@linux.vnet.ibm.com> <20130527154139.GH2373@dhcp-200-207.str.redhat.com> In-Reply-To: <20130527154139.GH2373@dhcp-200-207.str.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in block layer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: phrdina@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com, armbru@redhat.com 于 2013-5-27 23:41, Kevin Wolf 写道: > Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben: >> These patches are the common part of my hmp/qmp block query series and Pavel's >> qmp snapshot command converion series. It mainly does following things: >> 1 move snapshot related code to block/snapshot.c, qmp and info dumping code to >> block/qapi.c. >> 2 better info dumping function to get rid of buffer, avoid string truncation. > > Posted comments on patch 1 and 4. > > Patches 2 and 3 are: > Reviewed-by: Kevin Wolf > It seems nothing need change, Kevin, do you think it can be merged? -- Best Regards Wenchao Xia