From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ui2af-0006mf-Ej for qemu-devel@nongnu.org; Thu, 30 May 2013 09:08:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ui2aa-00028g-MW for qemu-devel@nongnu.org; Thu, 30 May 2013 09:08:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48463) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ui2aa-00028Q-FI for qemu-devel@nongnu.org; Thu, 30 May 2013 09:08:20 -0400 Message-ID: <51A74F34.1040304@redhat.com> Date: Thu, 30 May 2013 15:08:04 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20130529170459.GK23342@smtp.vpn> <51A6361D.50706@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 4/5] xilinx_devcfg: Zynq devcfg device model List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, blauwirbel@gmail.com, kraxel@redhat.com, Anthony Liguori , "Edgar E. Iglesias" Il 30/05/2013 09:15, Peter Crosthwaite ha scritto: >>> >> Hi Peter, Should we be putting r->access->name here instead of "devcfg-regs"? >> > >> > Yes, that's why I preferred to wrap the memory_region_init_io into an >> > API that takes a RegisterInfo. :) > ACK, > > You've convinced me :). Will be in v4 (pending outcome of discussion > with Anthony RE decoding) I would also have preferred (I was too terse in mentioning .accepts.valid earlier so this is the less concise explanation) an API that does a single memory_region_init_io region for a whole array of registers. Basically having a RegisterArrayInfo in addition to the RegisterInfo. Paolo