From: "Andreas Färber" <afaerber@suse.de>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target-i386: pc: fix crash when attempting hotplug CPU with negative ID
Date: Thu, 30 May 2013 17:24:35 +0200 [thread overview]
Message-ID: <51A76F33.2070606@suse.de> (raw)
In-Reply-To: <1369926574-27285-1-git-send-email-imammedo@redhat.com>
Am 30.05.2013 17:09, schrieb Igor Mammedov:
> QMP command "{ 'execute': 'cpu-add', 'arguments': { 'id': -1 }}" may cause
> QEMU SIGSEGV at:
> piix4_cpu_hotplug_req ()
> ...
> g->sts[cpu_id / 8] |= (1 << (cpu_id % 8));
> ...
>
> Since for PC in current implementation id should be in range [0...maxcpus)
> and maxcpus already checked, add check for lower bound and error out
> on incorrect value.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> hw/i386/pc.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
Thanks, applied to qom-cpu (with commit message massaged a bit):
https://github.com/afaerber/qemu-cpu/commits/qom-cpu
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2013-05-30 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 15:09 [Qemu-devel] [PATCH] target-i386: pc: fix crash when attempting hotplug CPU with negative ID Igor Mammedov
2013-05-30 15:24 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A76F33.2070606@suse.de \
--to=afaerber@suse.de \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).